From 9bc6c46dc391f166aaa16477bce8afc7061979ab Mon Sep 17 00:00:00 2001
From: bwhitn <brian.m.whitney@outlook.com>
Date: Sat, 16 Dec 2017 09:10:52 -0500
Subject: [PATCH] Fixed HOTP, TOTP and added test for HOTP

---
 src/core/operations/OTP.js   |  5 +++--
 test/index.js                |  1 +
 test/tests/operations/OTP.js | 23 +++++++++++++++++++++++
 3 files changed, 27 insertions(+), 2 deletions(-)
 create mode 100644 test/tests/operations/OTP.js

diff --git a/src/core/operations/OTP.js b/src/core/operations/OTP.js
index ff67d1c..2020505 100755
--- a/src/core/operations/OTP.js
+++ b/src/core/operations/OTP.js
@@ -1,5 +1,6 @@
 import otp from "otp";
 import Base64 from "./Base64.js";
+import Utils from "../Utils.js";
 
 /**
  * One-Time Password operations.
@@ -24,7 +25,7 @@ const OTP = {
             name: args[0],
             keySize: args[1],
             codeLength: args[2],
-            secret: Base64.runTo32(input, []),
+            secret: Base64.runTo32(Utils.strToByteArray(input), []),
             epoch: args[3],
             timeSlice: args[4]
         });
@@ -44,7 +45,7 @@ const OTP = {
             name: args[0],
             keySize: args[1],
             codeLength: args[2],
-            secret: Base64.runTo32(input, []),
+            secret: Base64.runTo32(Utils.strToByteArray(input), []),
         });
         const counter = args[3];
         return `URI: ${otpObj.hotpURL}\n\nPassword: ${otpObj.hotp(counter)}`;
diff --git a/test/index.js b/test/index.js
index 773a5b1..d444fc5 100644
--- a/test/index.js
+++ b/test/index.js
@@ -25,6 +25,7 @@ import "./tests/operations/Hash.js";
 import "./tests/operations/Image.js";
 import "./tests/operations/MorseCode.js";
 import "./tests/operations/MS.js";
+import "./tests/operations/OTP.js";
 import "./tests/operations/StrUtils.js";
 import "./tests/operations/SeqUtils.js";
 
diff --git a/test/tests/operations/OTP.js b/test/tests/operations/OTP.js
new file mode 100644
index 0000000..b321e7c
--- /dev/null
+++ b/test/tests/operations/OTP.js
@@ -0,0 +1,23 @@
+/**
+ * OTP HOTP tests.
+ *
+ * @author bwhitn [brian.m.whitney@outlook.com]
+ *
+ * @copyright Crown Copyright 2017
+ * @license Apache-2.0
+ */
+import TestRegister from "../../TestRegister.js";
+
+TestRegister.addTests([
+    {
+        name: "Generate HOTP",
+        input: "12345678901234567890",
+        expectedOutput: "URI: otpauth://hotp/OTPAuthentication?secret=GEZDGNBVGY3TQOJQGEZDGNBVGY3TQOJQ\n\nPassword: 755224",
+        recipeConfig: [
+            {
+                op: "Generate HOTP",
+                args: ["", 32, 6, 0],
+            },
+        ],
+    },
+]);