Commit Graph

9 Commits (66f724f3ad51c9b0de1c2cae3b22c69e08e51e49)

Author SHA1 Message Date
Jo-Philipp Wich 5a8864448a ppp: correct module loaded check in proto_pptp_setup
proto_pptp_setup is responsible for loading the required modules to establish
a pptp connection to a foreign peer. The function checks whether all required
modules are already loaded, before actually loading them.

It seems that the filter being used to accomplish this, is not restrictive
enough in some cases. For instance when pptp nat helper modules are present on
a system, and already loaded before a pptp connection is enabled. Then the
search filter (possibly) returns the following for module=pptp, where actually
no matches are expected, resulting in the pptp.ko module not being loaded,
thereby failing to establish the pptp connection.

# module="pptp" ; grep "$module" /proc/modules
nf_nat_pptp 1312 0 - Live 0x86ce7000
nf_conntrack_pptp 3072 1 nf_nat_pptp, Live 0x86cb9000
nf_nat_proto_gre 784 1 nf_nat_pptp, Live 0x86cba000
nf_conntrack_proto_gre 2368 1 nf_conntrack_pptp, Live 0x86cbf000
nf_nat 9792 13 nf_nat_rtsp,nf_nat_tftp,nf_nat_sip,nf_nat_pptp,nf_nat_h323,nf_nat_proto_gre,nf_nat_amanda,nf_nat_irc,nf_nat_ftp,ipt_REDIRECT,ipt_NETMAP,ipt_MASQUERADE,iptable_nat, Live 0x86ca8000
nf_conntrack 37264 31 nf_nat_rtsp,nf_conntrack_rtsp,nf_nat_tftp,nf_conntrack_tftp,nf_nat_snmp_basic,nf_conntrack_snmp,nf_nat_sip,nf_conntrack_sip,nf_nat_pptp,nf_conntrack_pptp,nf_nat_h323,nf_conntrack_h323,nf_conntrack_proto_gre,nf_nat_amanda,nf_conntrack_amanda,nf_conntrack_broadcast,nf_nat_irc,nf_conntrack_irc,nf_nat_ftp,nf_conntrack_ftp,ipt_MASQUERADE,iptable_nat,nf_nat,xt_helper,xt_connmark,xt_connbytes,xt_conntrack,xt_CT,xt_NOTRACK,xt_state,nf_conntrack_ipv4, Live 0x86c90000

The search filter can be made more accurate/restrictive, by requiring the
occurance of the exact name of the module at the beginning of a line in
/proc/modules.

# module="pptp" ; grep "^$module " /proc/modules
pptp 13296 2 - Live 0x86e80000

Signed-off-by: Tijs Van Buggenhout <tvb@able.be>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@38358 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-10-10 14:58:12 +00:00
Steven Barth 5882e71509 ppp: correctly handle address when reloading
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@36904 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-06-10 10:42:34 +00:00
Steven Barth 3e08305deb ppp: don't automatically set IPv6 default route
* Fixes "ndisc_router_discovery() failed to add default route"

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35188 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-01-17 08:28:57 +00:00
John Crispin 631fa2c18c [include] fixes uapi helper define
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34715 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-12-16 11:04:27 +00:00
John Crispin 599eec46ae [ppp] make use of uapi directory wrapper
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34684 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-12-15 01:59:19 +00:00
Jo-Philipp Wich 5308e09135 ppp: unconditionally start pppd with nodefaultroute and usepeerdns (#12580)
Since the switch to netifd, proto handlers may always set the defaultroute
and provide dns server addresses, netifd will decide in the generic code
path whether the announced values are masked or not.

Additionally protocol handlers should not modify the routing tables themselves
and prevent any launched services from doing so.

Remove the additional defaultroute and peerdns option handling from the ppp.sh
protocol handler and rely on netifd to mask or not mask the values.

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34536 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-12-06 18:17:21 +00:00
Jo-Philipp Wich 99bdb18a78 ppp:
- fix multilink ppp with custom ifnames, patch by George Kashperko <george@znau.edu.ua>
  - refresh patches

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34171 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-11-12 19:13:45 +00:00
Felix Fietkau a20833a4b8 ppp: add more pppol2tpv3 related structs from the kernel headers to fix compile issues with linux 3.6
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34070 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-11-04 17:01:27 +00:00
Felix Fietkau abe70b1494 packages: sort network related packages into package/network/
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@33688 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-10-10 12:32:29 +00:00