Commit Graph

39 Commits (4cef99c43896afbb6de688cd3cbf19a535ddaea1)

Author SHA1 Message Date
Felix Fietkau 2ee3482123 Fix a memory leak in hotplug2 environment handling.
Bump hotplug2 to the latest svn revision, remove obsolete patches.

Memory leak is caused by the way hotplug2 handles environment variables,
using setenv() and unsetenv(). setenv() creates copies of the supplied
strings, but, due to a POSIX blunder, these copies are never destroyed
by unsetenv(), neither in glibc nor uclibc - not until the program
terminates.

Since some events are handled directly in the main process, even when
configured with the "fork" worker, hotplug2 memory usage will keep
growing over time. This can be observed by running "udevtrigger" and
noting the increase in hotplug2 VmRSS after each run.

This patch uses putenv() instead, which leaves storage management to
the caller, so that we can explicitly delete stuff when it's no longer
needed.

Signed-off-by: Aleksandar Radovanovic <biblbroks@sezampro.rs>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@18725 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-12-09 18:50:49 +00:00
Felix Fietkau 3c635449d3 hotplug2: get rid of the unnecessary reference to libdl as well
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@18106 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-10-20 20:59:40 +00:00
Felix Fietkau 7a230fb6be hotplug2: compile in the worker module statically, saves >20k uncompressed
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@18104 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-10-20 20:49:44 +00:00
Felix Fietkau 15551bacbf hotplug2: fix "MALLOC FAILURE!" message caused by a missing return code check on recv()
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@18061 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-10-19 02:39:02 +00:00
Florian Fainelli 803c46476c [package] update hotplug2 to r199, fixes build failures on brcm-2.4
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@17508 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-09-03 18:33:52 +00:00
Jo-Philipp Wich 1777ea4ac0 [package] hotplug2 may need -fPIC
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@16199 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-05-29 23:11:29 +00:00
Hamish Guthrie c8804f6367 [hotplug2] added back atm rule
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@16137 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-05-28 13:31:30 +00:00
Hamish Guthrie 0cbd8a942f [hotplug2] add hotplug2 v1.0
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@16136 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-05-28 13:21:58 +00:00
Hamish Guthrie 6bb5dc043e [hotplug2] Move hotplug2 v0.9 to hotplug2-old
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@16135 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-05-28 13:20:54 +00:00
Florian Fainelli 580f0a8d67 [package] allow hotplug events to be triggered with the atm subsystem (#2996)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@16073 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-05-26 09:30:45 +00:00
Felix Fietkau 5bdd866100 get rid of $Id$ - it has never helped us and it has broken too many patches ;)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@15242 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-04-17 14:09:46 +00:00
Jose Vasconcellos c47c1e353e Use block events for the mounting/unmounting of external storage devices.
This handles both USB and IEEE1394 devices. It removes /sbin/usb-storage in
favor of using the block hotplug event. There are dummy scripts to handle the
plug in/out of USB and IEEE1394 devices for updating LEDs. Storage devices 
are mount as a sub-directory under /mnt.


git-svn-id: svn://svn.openwrt.org/openwrt/trunk@14289 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-01-30 20:48:42 +00:00
Gabor Juhos 25a9217e02 [package] hotplug2: add platform hotplugging
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@14248 3c298f89-4303-0410-b956-a3cf2f4a3e73
2009-01-28 20:01:11 +00:00
John Crispin 8929c4a880 remove warning from hotplug2, which pops up 10 times during boot
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@12086 3c298f89-4303-0410-b956-a3cf2f4a3e73
2008-08-04 08:04:16 +00:00
Felix Fietkau 13ab5b86e6 fix hotplug2 event processing deadlock
when bringing up ethernet on ixp4xx, the driver may request
a firmware while hotplug2 waits for the netdev bringup to complete.
change the event processing loop to keep an event backlog to allow
unthrottled events to pass through while throttled events are being waited for


git-svn-id: svn://svn.openwrt.org/openwrt/trunk@12019 3c298f89-4303-0410-b956-a3cf2f4a3e73
2008-07-30 19:02:01 +00:00
Nicolas Thill 1bc0fad874 move hotplug2 & udevtrigger to base section
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@10910 3c298f89-4303-0410-b956-a3cf2f4a3e73
2008-04-21 22:31:07 +00:00
Felix Fietkau 8422957bae refactor hotplug2 rules, make sure that the default button rule is only used during the init (should fix #2772)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@9644 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-12-01 17:08:04 +00:00
Felix Fietkau 6ad5c919ce bump package versions after updates
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@8680 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-09-07 20:41:57 +00:00
Nicolas Thill 2180fa92a1 move package description to a separate definition, remove it when DESCRIPTION=TITLE
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@8659 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-09-07 08:34:51 +00:00
John Crispin d4f61b29bc reduce watchdog trigger from 10 to 5 seconds
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@8571 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-09-01 21:01:09 +00:00
Felix Fietkau e1ec900c8e add watchdog start patch from #1967
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@8117 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-07-23 02:51:42 +00:00
Felix Fietkau 86b2e4df0e fix two small bugs in the hotplug2 rule parser (#2085)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@8023 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-07-18 07:23:40 +00:00
Felix Fietkau 07db8f80f9 move firmware loading to hotplug2-init.rules (should fix #2056)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7955 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-07-13 02:32:32 +00:00
Felix Fietkau a7e1a7ae99 hotplug2 update - include hotplug2-init.rules from hotplug2.rules, fix permissions of various devices (fixes #2052)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7892 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-07-09 00:13:47 +00:00
Felix Fietkau b1840ac964 replace the hotplug2 fork handling hack with a better solution implemented in upstream (thanks, iSteve)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7786 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-30 11:05:14 +00:00
Felix Fietkau c16aa532fe hotplug2: add fork handling optimization (also fixes that pesky pppoe race condition in #1655)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7726 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 09:47:58 +00:00
Felix Fietkau 923e4ce031 update to hotplug2 svn version (recommended by iSteve)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7725 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 09:46:37 +00:00
Felix Fietkau c209060116 fix failsafe on broadcom, send netlink events in diag when running linux 2.6
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7722 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 08:32:25 +00:00
Felix Fietkau 21e832921c hotplug2: add a missing cflag, allow hotplug events that are not 'add'
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7721 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 07:08:35 +00:00
Felix Fietkau f0f5892884 make hotplug2 use the build system cflags
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7720 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-25 06:30:36 +00:00
John Crispin a989402037 added usb-storage hotpluging
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7684 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-20 22:05:15 +00:00
Felix Fietkau 12a81e859f refresh all package patches in the buildroot using quilt
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7490 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-06-04 11:25:53 +00:00
Florian Fainelli 8d2dd06e4c Fix alsa-lib on 2.6 kernels, add an hotplug rule to populate /dev with the sound peripherals (#1677)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7246 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-05-15 08:20:31 +00:00
Felix Fietkau 629985c5aa fix firmware loading
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7115 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-05-06 16:03:38 +00:00
Felix Fietkau 4e4050b160 use hotplug2 for serializing hotplug events on 2.6
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@7097 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-05-05 18:33:18 +00:00
Felix Fietkau 713863458d add file type autodetection for the unpack command and nuke PKG_CAT:= in lots of places
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@6582 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-03-16 20:21:39 +00:00
Felix Fietkau c70cfb3d1a add a default for PKG_BUILD_DIR and PKG_INSTALL_DIR (will use KERNEL_BUILD_DIR if kernel.mk is included, BUILD_DIR otherwise)
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@6580 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-03-16 19:18:55 +00:00
Felix Fietkau 7c5ca4e5de make hotplug2 depend on udevtrigger
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@6511 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-03-04 20:15:32 +00:00
Felix Fietkau 91a5b05b8c add hotplug2
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@6510 3c298f89-4303-0410-b956-a3cf2f4a3e73
2007-03-04 19:55:47 +00:00