Commit Graph

23 Commits (19deb0cf132ecd6cd1b4aa79fcc4462c698a38dd)

Author SHA1 Message Date
Felix Fietkau 9eabad6fb3 cns3xxx: switch to using the upstream dwc2 driver instead of dwc_otg
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@43398 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-11-26 18:01:38 +00:00
Felix Fietkau f5d23c51b3 cns3xxx: set base device for ethernet port netdevs
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@43395 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-11-26 18:01:07 +00:00
Felix Fietkau dae2f62080 cns3xxx: fix passing the device to dma mapping ops
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@43394 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-11-26 18:00:52 +00:00
Felix Fietkau ac2d571b7d cns3xxx: update to linux 3.10
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@41917 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-07-31 23:40:49 +00:00
Felix Fietkau ee93382886 cns3xxx: ethernet - revert: clean up tx descs only when needed
This reverts commit 0772ab938c0aedd7f4cc7127059d6ce8cf929dfa.

Trying to optimize calls to eth_complete_tx in this fasion causes a regression
where when sending only the tx queue can get disabled until a packet is
received. This original call to eth_schedule_poll() is scheduled so it
should not cause a performance issue.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@40592 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-04-29 15:52:12 +00:00
Imre Kaloz 4c7b55c554 [cns3xxx]: various dwc (OTG) driver fixups
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Imre Kaloz <kaloz@openwrt.org>



git-svn-id: svn://svn.openwrt.org/openwrt/trunk@39892 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-03-12 13:37:40 +00:00
Felix Fietkau cad7ddfdc0 cns3xxx: ethernet - clean up tx descs only when needed
We already clean up tx descriptors in the napi eth_poll() function so it
would likely be rare to run out of available descriptors in eth_xmit. Thus
we can clean them up only when needed and return busy only when we
still don't have enough.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@39762 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-02-27 23:02:43 +00:00
Felix Fietkau cc53fad006 cns3xxx: ethernet - resolve SMP issue
The combination of r35942 and r35952 causes an issue where eth_schedule_poll()
can be called from a different CPU between the call to napi_complete() and the
setting of cur_index which can break the rx ring accounting and cause ethernet
latency and/or ethernet stalls.  The issue can be easilly created by adding
a couple of artificial delays such as:

@@ -715,6 +715,7 @@ static int eth_poll(struct napi_struct *napi, int budget)

 	if (!received) {
 		napi_complete(napi);
+udelay(1000);
 		enable_irq(IRQ_CNS3XXX_SW_R0RXC);
 	}

@@ -727,6 +728,7 @@ static int eth_poll(struct napi_struct *napi, int budget)
 	rx_ring->cur_index = i;

 	wmb();
+udelay(1000);
 	enable_rx_dma(sw);

 	return received;

This patch moves the setting of cur_index back up where it needs to be and
addresses the original corner case that r35942 was trying to catch in an
improved fashion by checking to see if the rx descriptor ring has become
full before interrupts were re-enabled so that a poll can be scheduled again
and avoid an rx stall caused by rx interrupts ceasing to fire again.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@39761 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-02-27 23:02:37 +00:00
Felix Fietkau df755284d9 cns3xxx: ethernet - clean the tx ring before refilling the rx ring to reduce memory pressure
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35953 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-11 02:29:53 +00:00
Felix Fietkau 4b1c2fb15f cns3xxx: ethernet - clean the tx ring only in the poll function, not in the xmit handler
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35952 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-11 02:29:47 +00:00
Felix Fietkau dfe1972d62 cns3xxx: increase number of ethernet driver rx buffers
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35951 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-10 21:59:32 +00:00
Felix Fietkau 1bb86e38d7 cns3xxx: prevent the ethernet driver from accessing uninitialized dma descriptor entries
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35950 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-10 21:59:28 +00:00
Felix Fietkau b019b3bb2f cns3xxx: minor ethernet driver cleanup
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35949 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-10 21:59:21 +00:00
Felix Fietkau f7b3da4d14 cns3xxx: use kmalloc instead of kzalloc for ethernet rx buffers
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35943 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-10 18:25:20 +00:00
Felix Fietkau 5dab5bf10c cns3xxx: fix an rx irq handling corner case
When an rx interrupt comes in, rx interrupts are disabled and NAPI
polling is scheduled. During the NAPI poll, the driver first processes
received frames in the ring, then fills the dma descriptor slots with
new buffers and calls tx complete, before finally re-enabling rx
interrupts and completing NAPI (if below the budget).
If the hardware rx queue overflows before the napi complete is called,
the hardware will not throw any further rx interrupts and rx processing
stops completely.
Fix this by keeping NAPI polling scheduled until it completes a poll
without receiving any packets, and also handle NAPI completion before
refilling rx or completing tx.

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35942 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-10 18:25:16 +00:00
Felix Fietkau 275672c3c9 cns3xxx: fix ethernet driver memory barrier usage
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35941 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-10 18:25:11 +00:00
Felix Fietkau 9ec6f799c1 cns3xxx: reduce buffer allocation size to 2048 bytes, improves ethernet performance
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35917 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-10 01:27:04 +00:00
Felix Fietkau 947ebaae8c cns3xxx: add linux 3.8 support and use it by default
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@35908 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-03-09 18:51:46 +00:00
Florian Fainelli d6328b1ebb cns3xxx: fix dwc_otg driver compat with udc-core
function.  This removes those from the dwc_otg driver and removes the patch
that comments out the linkage of udc-core so that the dwc_otg driver can
co-exist happily with other USB Device Controllers.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Florian Fainelli <florian@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34475 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-12-04 16:19:18 +00:00
Imre Kaloz 7a955260a6 [cns3xxx]: split spi patch, follow mainline file naming
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34168 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-11-12 08:22:14 +00:00
Imre Kaloz cba5b86e13 [cns3xxx]: split the i2c patch, merge the retry fixup
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34167 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-11-12 08:21:38 +00:00
Luka Perkov 37b69da0ca cns3xxx: convert dwc_otg patches to files
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34162 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-11-11 20:03:58 +00:00
Luka Perkov 80a28570bd cns3xxx: convert ethernet patches to files
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34161 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-11-11 20:03:56 +00:00