hak5
/
openwrt
mirror of https://github.com/hak5/openwrt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ar71xx: ethernet: cache skb->len in the tx function to avoid accessing it again in completion 

Improves ethernet performance, especially during bridging

Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 37761
lede-17.01
Felix Fietkau 2013-08-12 17:26:00 +00:00
parent e5fd991c6c
commit f43b4ea962
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h
View File

@ -91,9 +91,12 @@ struct ag71xx_buf {
void *rx_buf; void *rx_buf;
}; };
struct ag71xx_desc *desc; struct ag71xx_desc *desc;
union {
dma_addr_t dma_addr; dma_addr_t dma_addr;
unsigned long timestamp; unsigned long timestamp;
}; };
unsigned int len;
};
struct ag71xx_ring { struct ag71xx_ring {
struct ag71xx_buf *buf; struct ag71xx_buf *buf;

8
target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c
View File

@ -145,7 +145,7 @@ static void ag71xx_ring_tx_clean(struct ag71xx *ag)
} }
if (ring->buf[i].skb) { if (ring->buf[i].skb) {
bytes_compl += ring->buf[i].skb->len; bytes_compl += ring->buf[i].len;
pkts_compl++; pkts_compl++;
dev_kfree_skb_any(ring->buf[i].skb); dev_kfree_skb_any(ring->buf[i].skb);
} }
@ -684,6 +684,7 @@ static netdev_tx_t ag71xx_hard_start_xmit(struct sk_buff *skb,
DMA_TO_DEVICE); DMA_TO_DEVICE);
netdev_sent_queue(dev, skb->len); netdev_sent_queue(dev, skb->len);
ring->buf[i].len = skb->len;
ring->buf[i].skb = skb; ring->buf[i].skb = skb;
ring->buf[i].timestamp = jiffies; ring->buf[i].timestamp = jiffies;
@ -824,6 +825,7 @@ static int ag71xx_tx_packets(struct ag71xx *ag)
unsigned int i = ring->dirty % ring->size; unsigned int i = ring->dirty % ring->size;
struct ag71xx_desc *desc = ring->buf[i].desc; struct ag71xx_desc *desc = ring->buf[i].desc;
struct sk_buff *skb = ring->buf[i].skb; struct sk_buff *skb = ring->buf[i].skb;
int len = ring->buf[i].len;
if (!ag71xx_desc_empty(desc)) { if (!ag71xx_desc_empty(desc)) {
if (pdata->is_ar7240 && if (pdata->is_ar7240 &&
@ -834,8 +836,8 @@ static int ag71xx_tx_packets(struct ag71xx *ag)
ag71xx_wr(ag, AG71XX_REG_TX_STATUS, TX_STATUS_PS); ag71xx_wr(ag, AG71XX_REG_TX_STATUS, TX_STATUS_PS);
bytes_compl += skb->len; bytes_compl += len;
ag->dev->stats.tx_bytes += skb->len; ag->dev->stats.tx_bytes += len;
ag->dev->stats.tx_packets++; ag->dev->stats.tx_packets++;
dev_kfree_skb_any(skb); dev_kfree_skb_any(skb);