hak5
/
openwrt
mirror of https://github.com/hak5/openwrt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kernel/4.14: add missing newline character to UBI messages 

A few UBI messages lacks the trailing newline character which
leads to ugly lines in the bootlog like this:

  [    6.649159] UBI error: no valid UBI magic found inside mtd6[    6.667751] Freeing unused kernel memory: 2196K

Add a newline character to the end of the messages to fix it.
After the fix the line from above looks better in the log:

  [    6.609182] UBI error: no valid UBI magic found inside mtd6
  [    6.627599] Freeing unused kernel memory: 2132K

Signed-off-by: Gabor Juhos <juhosg@freemail.hu>
openwrt-18.06
Gabor Juhos 2017-12-19 09:11:57 +01:00 committed by John Crispin
parent 975e9cd866
commit df68e63a4f
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
target/linux/generic/pending-4.14/490-ubi-auto-attach-mtd-device-named-ubi-or-data-on-boot.patch
View File

@ -33,7 +33,7 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org>
+ /* check for a valid ubi magic */ + /* check for a valid ubi magic */
+ err = mtd_read(mtd, 0, 4, &len, (void *) magic); + err = mtd_read(mtd, 0, 4, &len, (void *) magic);
+ if (!err && len == 4 && strncmp(magic, "UBI#", 4)) { + if (!err && len == 4 && strncmp(magic, "UBI#", 4)) {
+ pr_err("UBI error: no valid UBI magic found inside mtd%d", mtd->index); + pr_err("UBI error: no valid UBI magic found inside mtd%d\n", mtd->index);
+ put_mtd_device(mtd); + put_mtd_device(mtd);
+ return; + return;
+ } + }
@ -48,7 +48,7 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org>
+ err = ubi_attach_mtd_dev(mtd, UBI_DEV_NUM_AUTO, 0, 0); + err = ubi_attach_mtd_dev(mtd, UBI_DEV_NUM_AUTO, 0, 0);
+ mutex_unlock(&ubi_devices_mutex); + mutex_unlock(&ubi_devices_mutex);
+ if (err < 0) { + if (err < 0) {
+ pr_err("UBI error: cannot attach mtd%d", mtd->index); + pr_err("UBI error: cannot attach mtd%d\n", mtd->index);
+ put_mtd_device(mtd); + put_mtd_device(mtd);
+ } + }
+ } + }

2
target/linux/generic/pending-4.14/494-mtd-ubi-add-EOF-marker-support.patch
View File

@ -36,7 +36,7 @@ Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
+ return err; + return err;
+ +
+ if (ec_hdr_has_eof(ech)) { + if (ec_hdr_has_eof(ech)) {
+ pr_notice("UBI: EOF marker found, PEBs from %d will be erased", + pr_notice("UBI: EOF marker found, PEBs from %d will be erased\n",
+ pnum); + pnum);
+ ai->eof_found = true; + ai->eof_found = true;
+ } + }