hak5
/
openwrt
mirror of https://github.com/hak5/openwrt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

busybox: disable default config option FEATURE_SUID=y 

Commit ad7c6102f2 ("busybox: fix missing install with suid bit set if
FEATURE_SUID=y") actually fixes BUSYBOX_CONFIG_FEATURE_SUID option and
thus would install busybox setuid root by default which would result in
possibly unwanted change of current behaviour, so let's disable this
option by default in order to preserve the current status-quo.

For the record: disabling FEATURE_SUID to preserve the status-quo does
*not* imply the current status-quo is "safer", or for that matter, in
any way desireable.  That is a discussion to be had on the mailing
lists.

Switching the FEATURE_SUID default to "n" is simply a compromise to
facilitate the merge of the changes that unbreak FEATURE_SUID.

Ref: PR#2502
Signed-off-by: Henrique de Moraes Holschuh <henrique@nic.br>
[commit title/description facelift]
Signed-off-by: Petr Štetiar <ynezz@true.cz>
master
Henrique de Moraes Holschuh 2019-11-01 08:56:50 -03:00 committed by Petr Štetiar
parent ad7c6102f2
commit 8eab0a0036
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package/utils/busybox/Config-defaults.in
View File

@ -60,7 +60,7 @@ config BUSYBOX_DEFAULT_INSTALL_NO_USR
default n default n
config BUSYBOX_DEFAULT_FEATURE_SUID config BUSYBOX_DEFAULT_FEATURE_SUID
bool bool
default y default n
config BUSYBOX_DEFAULT_FEATURE_SUID_CONFIG config BUSYBOX_DEFAULT_FEATURE_SUID_CONFIG
bool bool
default n default n