hak5
/
openwrt
mirror of https://github.com/hak5/openwrt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PKG_CHECK_FORMAT_SECURITY: add a menuconfig option, disable by default 

The idea is still to enable it by default at some point
I've tested all ar71xx packages (except oldpackages) using CONFIG_ALL=y
Failing packages have been marked with PKG_CHECK_FORMAT_SECURITY:=0 for now
I can test more targets but i have no idea which are the most used

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>

SVN-Revision: 42282
lede-17.01
John Crispin 2014-08-25 06:36:06 +00:00
parent bbcf1fa610
commit 7a1f4c50fa
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
config/Config-build.in
View File

@ -93,6 +93,15 @@ menu "Global build settings"
If you are unsure, select N. If you are unsure, select N.
config PKG_CHECK_FORMAT_SECURITY
bool
prompt "Enable gcc format-security"
default n
help
Add -Wformat -Werror=format-security to the CFLAGS
You can disable this per package by adding
PKG_CHECK_FORMAT_SECURITY:=0 in the package Makefile
config PKG_BUILD_USE_JOBSERVER config PKG_BUILD_USE_JOBSERVER
bool bool
prompt "Use top-level make jobserver for packages" prompt "Use top-level make jobserver for packages"

6
include/package.mk
View File

@ -14,7 +14,7 @@ PKG_INSTALL_DIR ?= $(PKG_BUILD_DIR)/ipkg-install
PKG_MD5SUM ?= unknown PKG_MD5SUM ?= unknown
PKG_BUILD_PARALLEL ?= PKG_BUILD_PARALLEL ?=
PKG_USE_MIPS16 ?= 1 PKG_USE_MIPS16 ?= 1
PKG_CHECK_FORMAT_SECURITY ?= 0 PKG_CHECK_FORMAT_SECURITY ?= 1
ifneq ($(CONFIG_PKG_BUILD_USE_JOBSERVER),) ifneq ($(CONFIG_PKG_BUILD_USE_JOBSERVER),)
MAKE_J:=$(if $(MAKE_JOBSERVER),$(MAKE_JOBSERVER) -j) MAKE_J:=$(if $(MAKE_JOBSERVER),$(MAKE_JOBSERVER) -j)
@ -34,8 +34,10 @@ ifdef CONFIG_USE_MIPS16
TARGET_CFLAGS += -mips16 -minterlink-mips16 TARGET_CFLAGS += -mips16 -minterlink-mips16
endif endif
endif endif
ifeq ($(strip $(PKG_CHECK_FORMAT_SECURITY)),1) ifdef CONFIG_PKG_CHECK_FORMAT_SECURITY
ifeq ($(strip $(PKG_CHECK_FORMAT_SECURITY)),1)
TARGET_CFLAGS += -Wformat -Werror=format-security TARGET_CFLAGS += -Wformat -Werror=format-security
endif
endif endif
include $(INCLUDE_DIR)/prereq.mk include $(INCLUDE_DIR)/prereq.mk