ath79: fix/improve LED control for TL-WPA8630 v1/v2

The TL-WPA8630 v1 and v2 have the same LED Control GPIO configuration
according to the TP-Link GPL sources. Set the GPIO to output to make
it work and set to Active Low. It defaults to LEDs on at bootup.

To turn all LEDs off:
  echo 0 > /sys/class/gpio/tp-link\:led\:control/value
To turn all LEDs on:
  echo 1 > /sys/class/gpio/tp-link\:led\:control/value

Change the "LED" button from BTN_0 to KEY_LIGHTS_TOGGLE to match other
devices and the button guide, and to reduce the number of unintuitive
"BTN_X" inputs.

Fixes: ab74def0db ("ath79: add support for TP-Link TL-WPA8630P v2")

Signed-off-by: Joe Mullally <jwmullally@gmail.com>
[shorten commit title, minor commit message adjustments]
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
master
Joe Mullally 2020-08-21 07:02:23 +01:00 committed by Adrian Schmutzler
parent 441b36236f
commit 685d2513b5
2 changed files with 11 additions and 10 deletions

View File

@ -25,7 +25,7 @@
leds {
label = "LED control button";
linux,code = <BTN_0>;
linux,code = <KEY_LIGHTS_TOGGLE>;
gpios = <&gpio 6 GPIO_ACTIVE_LOW>;
debounce-interval = <60>;
};
@ -70,6 +70,16 @@
linux,default-trigger = "phy0tpt";
};
};
gpio-export {
compatible = "gpio-export";
led_control {
gpio-export,name = "tp-link:led:control";
gpio-export,output = <0>;
gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
};
};
};
&spi {

View File

@ -6,15 +6,6 @@
aliases {
label-mac-device = &eth0;
};
gpio-export {
compatible = "gpio-export";
led_control {
gpio-export,name = "tp-link:led:control";
gpios = <&gpio 14 GPIO_ACTIVE_HIGH>;
};
};
};
&partitions {