From 4ffed014a36b3d3ed9d71227adb8158ac8fd7564 Mon Sep 17 00:00:00 2001 From: Mathias Kresin Date: Wed, 22 Aug 2018 06:26:36 +0200 Subject: [PATCH] ramips: drop not existing groups from pinmux RT5350 neither have rgmii nor a mdio pinmux group. MT7628an doesn't have a jtag group. Having these groups defined might cause a boot panic. The pin controller fails to initialise for kernels > 4.9 if invalid groups are used. If a subsystem references a pin controller configuration node, it can not find this node and errors out. In worst case it's the SPI driver which errors out and we have no root filesystem to mount. Signed-off-by: Mathias Kresin --- target/linux/ramips/dts/3G150B.dts | 2 +- target/linux/ramips/dts/ALL5003.dts | 2 +- target/linux/ramips/dts/DIR-300-B7.dts | 2 +- target/linux/ramips/dts/DIR-320-B1.dts | 2 +- target/linux/ramips/dts/MPRA1.dts | 2 +- target/linux/ramips/dts/MPRA2.dts | 2 +- target/linux/ramips/dts/NCS601W.dts | 2 +- target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi | 2 +- target/linux/ramips/dts/WIZARD8800.dts | 2 +- target/linux/ramips/dts/WRTNODE2P.dts | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/target/linux/ramips/dts/3G150B.dts b/target/linux/ramips/dts/3G150B.dts index afe9fafe9b..7355e78ca7 100644 --- a/target/linux/ramips/dts/3G150B.dts +++ b/target/linux/ramips/dts/3G150B.dts @@ -90,7 +90,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "jtag", "rgmii", "mdio", "uartf", "led"; + ralink,group = "i2c", "jtag", "uartf", "led"; ralink,function = "gpio"; }; }; diff --git a/target/linux/ramips/dts/ALL5003.dts b/target/linux/ramips/dts/ALL5003.dts index a740455ae0..7196089214 100644 --- a/target/linux/ramips/dts/ALL5003.dts +++ b/target/linux/ramips/dts/ALL5003.dts @@ -87,7 +87,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "jtag", "rgmii", "mdio", "uartf"; + ralink,group = "i2c", "jtag", "uartf"; ralink,function = "gpio"; }; }; diff --git a/target/linux/ramips/dts/DIR-300-B7.dts b/target/linux/ramips/dts/DIR-300-B7.dts index 12ccd1620d..f4741ea136 100644 --- a/target/linux/ramips/dts/DIR-300-B7.dts +++ b/target/linux/ramips/dts/DIR-300-B7.dts @@ -81,7 +81,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "jtag", "rgmii", "mdio", "uartf"; + ralink,group = "i2c", "jtag", "uartf"; ralink,function = "gpio"; }; }; diff --git a/target/linux/ramips/dts/DIR-320-B1.dts b/target/linux/ramips/dts/DIR-320-B1.dts index 9e05b63e98..4dc877cf47 100644 --- a/target/linux/ramips/dts/DIR-320-B1.dts +++ b/target/linux/ramips/dts/DIR-320-B1.dts @@ -103,7 +103,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "jtag", "rgmii", "mdio", "uartf"; + ralink,group = "i2c", "jtag", "uartf"; ralink,function = "gpio"; }; }; diff --git a/target/linux/ramips/dts/MPRA1.dts b/target/linux/ramips/dts/MPRA1.dts index 59dfe4ebd2..457a914179 100644 --- a/target/linux/ramips/dts/MPRA1.dts +++ b/target/linux/ramips/dts/MPRA1.dts @@ -96,7 +96,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "jtag", "rgmii", "mdio", "uartf", "led"; + ralink,group = "i2c", "jtag", "uartf", "led"; ralink,function = "gpio"; }; }; diff --git a/target/linux/ramips/dts/MPRA2.dts b/target/linux/ramips/dts/MPRA2.dts index 4bf9b57549..01883f8f72 100644 --- a/target/linux/ramips/dts/MPRA2.dts +++ b/target/linux/ramips/dts/MPRA2.dts @@ -92,7 +92,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "jtag", "rgmii", "mdio", "uartf"; + ralink,group = "i2c", "jtag", "uartf"; ralink,function = "gpio"; }; }; diff --git a/target/linux/ramips/dts/NCS601W.dts b/target/linux/ramips/dts/NCS601W.dts index 500fdf9740..c935f25acc 100644 --- a/target/linux/ramips/dts/NCS601W.dts +++ b/target/linux/ramips/dts/NCS601W.dts @@ -45,7 +45,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "jtag", "rgmii", "mdio", "uartf"; + ralink,group = "i2c", "jtag", "uartf"; ralink,function = "gpio"; }; }; diff --git a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi index 629dab8934..62c2583f7a 100644 --- a/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi +++ b/target/linux/ramips/dts/RT5350F-OLINUXINO.dtsi @@ -52,7 +52,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "jtag", "rgmii", "mdio"; + ralink,group = "jtag"; ralink,function = "gpio"; }; uartf_gpio { diff --git a/target/linux/ramips/dts/WIZARD8800.dts b/target/linux/ramips/dts/WIZARD8800.dts index 3cd48cdeb4..1379a247fa 100644 --- a/target/linux/ramips/dts/WIZARD8800.dts +++ b/target/linux/ramips/dts/WIZARD8800.dts @@ -53,7 +53,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "jtag", "rgmii", "mdio", "uartf"; + ralink,group = "i2c", "jtag", "uartf"; ralink,function = "gpio"; }; }; diff --git a/target/linux/ramips/dts/WRTNODE2P.dts b/target/linux/ramips/dts/WRTNODE2P.dts index 53619138b1..9c5864875f 100644 --- a/target/linux/ramips/dts/WRTNODE2P.dts +++ b/target/linux/ramips/dts/WRTNODE2P.dts @@ -19,7 +19,7 @@ &pinctrl { state_default: pinctrl0 { gpio { - ralink,group = "i2c", "gpio", "jtag"; + ralink,group = "i2c", "gpio"; ralink,function = "gpio"; }; };