From 18fbb9aa21740aa698af3d7e8e53a62d8ff014c9 Mon Sep 17 00:00:00 2001 From: Adrian Schmutzler Date: Wed, 12 Aug 2020 14:26:44 +0200 Subject: [PATCH] ath79: fix ethernet setup for some qca953x devices On Comfast CF-E130N v2 and Mikrotik LHG HB board, the config found in DTS appears to be strange: - eth0 has "syscon","simple-mfd" set although it's not enabled - eth1 is enabled redundantly (already "okay" in qca953x.dtsi) - phy-handle is set for eth1 in DTS although it has a fixed-link in qca953x.dtsi This seems like a copy-paste gone wrong. Remove the named options. Run-tested on MikroTik LHG 2. Signed-off-by: Adrian Schmutzler --- target/linux/ath79/dts/qca9531_comfast_cf-e130n-v2.dts | 9 --------- .../ath79/dts/qca9533_mikrotik_routerboard-lhg-hb.dtsi | 8 -------- 2 files changed, 17 deletions(-) diff --git a/target/linux/ath79/dts/qca9531_comfast_cf-e130n-v2.dts b/target/linux/ath79/dts/qca9531_comfast_cf-e130n-v2.dts index a6ef6ad99c..2355176356 100644 --- a/target/linux/ath79/dts/qca9531_comfast_cf-e130n-v2.dts +++ b/target/linux/ath79/dts/qca9531_comfast_cf-e130n-v2.dts @@ -122,18 +122,9 @@ &uart { status = "okay"; - -}; - -ð0 { - compatible = "syscon", "simple-mfd"; }; ð1 { - status = "okay"; - - phy-handle = <&swphy0>; - mtd-mac-address = <&art 0x0>; gmac-config { diff --git a/target/linux/ath79/dts/qca9533_mikrotik_routerboard-lhg-hb.dtsi b/target/linux/ath79/dts/qca9533_mikrotik_routerboard-lhg-hb.dtsi index 32cc6d3731..86249398c9 100644 --- a/target/linux/ath79/dts/qca9533_mikrotik_routerboard-lhg-hb.dtsi +++ b/target/linux/ath79/dts/qca9533_mikrotik_routerboard-lhg-hb.dtsi @@ -67,15 +67,7 @@ }; }; -ð0 { - compatible = "syscon", "simple-mfd"; -}; - ð1 { - status = "okay"; - - phy-handle = <&swphy0>; - gmac-config { device = <&gmac>; };