hak5
/
nano-tetra-modules
mirror of https://github.com/hak5/nano-tetra-modules.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OpenVPNConnect 1.3 Update - RCE Bug Fix and Dependency Handling Bug Fix (#77)

pull/72/merge
Casey Erdmann 2019-09-27 15:53:17 -04:00 committed by Marc
parent b45e52ccf1
commit d89ddc8f18
4 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
OpenVPNConnect/api/module.php
View File

@ -27,7 +27,7 @@ class OpenVPNConnect extends Module{
$this->initializeModule();
break;
case 'handleDependencies':
$this->handleDependencies();
$this->handleDependencies(false);
break;
case 'handleDependenciesSDCard':
$this->handleDependenciesSDCard();
@ -104,7 +104,6 @@ class OpenVPNConnect extends Module{
// Handles dependency installation and removal
private function handleDependencies($sd){
if($this->checkDependency('openvpn')){
$this->execBackground('opkg remove openvpn-openssl');
$messsage = "Dependencies should now be removed! Note: the vpn_config directory is NOT removed in this process. Please wait for the page to refresh...";
@ -158,7 +157,7 @@ class OpenVPNConnect extends Module{
$open_vpn_cmd = "openvpn --log /pineapple/modules/OpenVPNConnect/log/vpn.log --status /pineapple/modules/OpenVPNConnect/log/status.log --config ";
if($inputData[0] != ''){
$config_name = $inputData[0];
$config_name = escapeshellcmd($inputData[0]);
$open_vpn_cmd .= "/root/vpn_config/" . $config_name . " ";
}else{
$this->response = array("success" => false,
@ -189,7 +188,7 @@ class OpenVPNConnect extends Module{
if($inputData[3] != ''){
$openvpn_flags = $inputData[3];
$openvpn_flags = escapeshellcmd($inputData[3]);
$open_vpn_cmd .= $openvpn_flags;
}

2
OpenVPNConnect/js/module.js
View File

@ -43,7 +43,7 @@ registerController('openVPNConnectController', ['$api', '$scope', '$timeout', '$
$timeout(function() {$window.location.reload();}, 5000);
}
//console.log(response) //Log the response to the console, this is useful for debugging.
//console.log(response) //Log the response to the console, this is useful for debugging.
});
}

14
OpenVPNConnect/module.html
View File

@ -141,15 +141,23 @@
</div>
<div id="collapseChangelog" class="panel-collapse collapse">
<div class="panel-body">
<ul>
<ul>
<li>
<b>1.0.2 </b>
<b>1.3 </b>
</li>
<ul>
<li class="text-muted">Now with no RCEs :D...Fixed a major RCE caused by not sanitizing user input when passing in certain OpenVPN parameters.</li>
<li class="text-muted">Added stability improvements for package management for those with fresh upgrades to 2.6.X WiFi Pineapple firmware.</li>
<li class="text-muted">Lastly, revised the revision numbers to fall in line with the formal releases.</li>
</ul>
<li>
<b>1.2 </b>
</li>
<ul>
<li class="text-muted">Added in current status when revisiting page, logging, and ability to install dependencies to SD card or local storage. Also squashed some bugs :)</li>
</ul>
<li>
<b>1.0.1 </b>
<b>1.1 </b>
</li>
<ul>
<li class="text-muted">Minor Revisions: Added better iptables management with dynamic gateway and the ability to use auth-user-pass. Unofficial Release (Github Only)</li>

2
OpenVPNConnect/module.info
View File

@ -6,5 +6,5 @@
"tetra"
],
"title": "OpenVPNConnect",
"version": "1.2"
"version": "1.3"
}