ch0ic3/cutter
1
0
Fork 0
mirror of https://github.com/rizinorg/cutter.git synced 2024-12-18 19:06:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove Fallback for afcf in Graph Header (#1090)

Browse Source 
since afcf now works for all functions in r2 this is not needed anymore and will greatly improve performance
This commit is contained in:
Florian Märkl 2019-01-10 15:49:31 +01:00 committed by GitHub
parent 80b68a0cc8
commit f189fb423c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/widgets/DisassemblerGraphView.cpp
View File

@ -352,39 +352,12 @@ void DisassemblerGraphView::prepareGraphNode(GraphBlock &block)
void DisassemblerGraphView::prepareHeader()
{
QString afcf = Core()->cmd("afcf").trimmed();
if (afcf.length() > 0) {
header->setPlainText(afcf);
header->show();
return;
}
QJsonArray func = Core()->cmdj("afij").array();
QJsonValue value = func.first();
QJsonObject obj = value.toObject();
QString name = obj["name"].toString().trimmed();
if (name.isEmpty()) {
if (afcf.isEmpty()) {
header->hide();
return;
}
QString ret = obj["calltype"].toString().trimmed();
ret += (" ") + name + ("(");
QJsonArray args = obj["bpvars"].toArray();
QString argNames = QString();
for (QJsonValue value : args) {
QJsonObject obj = value.toObject();
QString kind = obj["kind"].toString();
if (kind == "arg") {
QString typeName = obj["type"].toString().trimmed();
QString argName = obj["name"].toString().trimmed();
if (argNames.isEmpty()) {
argNames += typeName + (" ") + argName;
} else {
argNames += (", ") + typeName + (" ") + argName;
}
}
}
ret += argNames + (")");
header->setPlainText(ret);
header->show();
header->setPlainText(afcf);
}
void DisassemblerGraphView::initFont()
@ -692,7 +665,6 @@ void DisassemblerGraphView::onSeekChanged(RVA addr)
transition_dont_seek = true;
showBlock(&blocks[db->entry], true);
prepareHeader();
return;
} else {
refreshView();
db = blockForAddress(addr);
@ -701,7 +673,8 @@ void DisassemblerGraphView::onSeekChanged(RVA addr)
transition_dont_seek = true;
showBlock(&blocks[db->entry], true);
prepareHeader();
return;
} else {
header->hide();
}
}
}