From e115cbc9e990cf599ed9d771a621c52c36247417 Mon Sep 17 00:00:00 2001 From: fcasal Date: Sun, 4 Mar 2018 23:16:54 +0000 Subject: [PATCH] Fixed sorting in Strings widget (#354) Sorting by string, type, size or length now works when selecting the corresponding column. --- src/widgets/StringsWidget.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/widgets/StringsWidget.cpp b/src/widgets/StringsWidget.cpp index 3f7ba560..3c8c6baf 100644 --- a/src/widgets/StringsWidget.cpp +++ b/src/widgets/StringsWidget.cpp @@ -116,9 +116,14 @@ bool StringsSortFilterProxyModel::lessThan(const QModelIndex &left, const QModel case StringsModel::OFFSET: if (left_str.vaddr != right_str.vaddr) return left_str.vaddr < right_str.vaddr; - // fallthrough - case StringsModel::STRING: + case StringsModel::STRING: // sort by string return left_str.string < right_str.string; + case StringsModel::TYPE: // sort by type + return left_str.type < right_str.type; + case StringsModel::SIZE: // sort by size + return left_str.size < right_str.size; + case StringsModel::LENGTH: // sort by length + return left_str.length < right_str.length; default: break; }