From 84d4a64f47b26759680c9d5c914f1f4f30f10cf9 Mon Sep 17 00:00:00 2001
From: Segev Finer <segev208@gmail.com>
Date: Sat, 5 Feb 2022 08:51:36 +0200
Subject: [PATCH] Enable console redirection on Windows without starting from a
 console (#2888)

---
 src/Main.cpp | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/Main.cpp b/src/Main.cpp
index 89101b11..b0cef4a0 100644
--- a/src/Main.cpp
+++ b/src/Main.cpp
@@ -12,15 +12,11 @@
 
 /**
  * @brief Attempt to connect to a parent console and configure outputs.
- *
- * @note Doesn't do anything if the exe wasn't executed from a console.
  */
 #ifdef Q_OS_WIN
 static void connectToConsole()
 {
-    if (!AttachConsole(ATTACH_PARENT_PROCESS)) {
-        return;
-    }
+    BOOL attached = AttachConsole(ATTACH_PARENT_PROCESS);
 
     // Avoid reconfiguring stdin/stderr/stdout if one of them is already connected to a stream.
     // This can happen when running with stdout/stderr redirected to a file.
@@ -32,12 +28,12 @@ static void connectToConsole()
         // _open() after startup.
         _close(0);
 
-        freopen("CONIN$", "r+", stdin);
+        freopen(attached ? "CONIN$" : "NUL", "r+", stdin);
     }
     if (0 > fileno(stdout)) {
         _close(1);
 
-        if (freopen("CONOUT$", "a+", stdout)) {
+        if (freopen(attached ? "CONOUT$" : "NUL", "a+", stdout)) {
             // Avoid buffering stdout/stderr since IOLBF is replaced by IOFBF in Win32.
             setvbuf(stdout, nullptr, _IONBF, 0);
         }
@@ -45,7 +41,7 @@ static void connectToConsole()
     if (0 > fileno(stderr)) {
         _close(2);
 
-        if (freopen("CONOUT$", "a+", stderr)) {
+        if (freopen(attached ? "CONOUT$" : "NUL", "a+", stderr)) {
             setvbuf(stderr, nullptr, _IONBF, 0);
         }
     }