ch0ic3/cutter
1
0
Fork 0
mirror of https://github.com/rizinorg/cutter.git synced 2025-01-18 10:35:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix crash in hexdump, issue #163

Browse Source 
To prevent recursive calls to hexScrolled block the signals of the
verticalScrollBars of the QTextEdit widgets.
This commit is contained in:
ballessay 2017-05-13 17:25:36 +02:00 committed by C. Balles
parent 44d1b0454f
commit 6ffb18e6e4
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/widgets/memorywidget.cpp
View File

@ -750,9 +750,18 @@ void MemoryWidget::hexScrolled()
QList<QString> ret = this->get_hexdump(lastline);
this->hexOffsetText->append(ret[0]);
this->hexHexText->append(ret[1]);
this->hexASCIIText->append(ret[2]);
// To prevent recursive calls to hexScrolled (this function) blocks the
// scroll bar signals
auto appendTextWithoutSignals = [](QTextEdit *edit, const QString &text)
{
edit->verticalScrollBar()->blockSignals(true);
edit->append(text);
edit->verticalScrollBar()->blockSignals(false);
};
appendTextWithoutSignals(hexOffsetText, ret[0]);
appendTextWithoutSignals(hexHexText, ret[1]);
appendTextWithoutSignals(hexASCIIText, ret[2]);
this->resizeHexdump();
// Append more hex text here