diff --git a/src/widgets/BreakpointWidget.cpp b/src/widgets/BreakpointWidget.cpp index a2f8f64c..3aadf100 100644 --- a/src/widgets/BreakpointWidget.cpp +++ b/src/widgets/BreakpointWidget.cpp @@ -127,8 +127,8 @@ BreakpointWidget::BreakpointWidget(MainWindow *main, QAction *action) : }); setScrollMode(); - actionDelBreakpoint = new QAction(tr("Delete breakpoint")); - actionToggleBreakpoint = new QAction(tr("Toggle breakpoint")); + actionDelBreakpoint = new QAction(tr("Delete breakpoint"), this); + actionToggleBreakpoint = new QAction(tr("Toggle breakpoint"), this); connect(actionDelBreakpoint, &QAction::triggered, this, &BreakpointWidget::delBreakpoint); connect(actionToggleBreakpoint, &QAction::triggered, this, &BreakpointWidget::toggleBreakpoint); connect(Core(), &CutterCore::refreshAll, this, &BreakpointWidget::refreshBreakpoint); diff --git a/src/widgets/DebugActions.cpp b/src/widgets/DebugActions.cpp index dcbb044c..ee2b6fc1 100644 --- a/src/widgets/DebugActions.cpp +++ b/src/widgets/DebugActions.cpp @@ -68,7 +68,7 @@ DebugActions::DebugActions(QToolBar *toolBar, MainWindow *main) : QToolButton *startButton = new QToolButton; startButton->setPopupMode(QToolButton::MenuButtonPopup); connect(startButton, &QToolButton::triggered, startButton, &QToolButton::setDefaultAction); - QMenu *startMenu = new QMenu; + QMenu *startMenu = new QMenu(startButton); // only emulation is currently allowed // startMenu->addAction(actionStart); @@ -82,7 +82,7 @@ DebugActions::DebugActions(QToolBar *toolBar, MainWindow *main) : continueUntilButton->setPopupMode(QToolButton::MenuButtonPopup); connect(continueUntilButton, &QToolButton::triggered, continueUntilButton, &QToolButton::setDefaultAction); - QMenu *continueUntilMenu = new QMenu; + QMenu *continueUntilMenu = new QMenu(continueUntilButton); continueUntilMenu->addAction(actionContinueUntilMain); continueUntilMenu->addAction(actionContinueUntilCall); continueUntilMenu->addAction(actionContinueUntilSyscall); diff --git a/src/widgets/HexWidget.cpp b/src/widgets/HexWidget.cpp index dcaaf418..54b810a4 100644 --- a/src/widgets/HexWidget.cpp +++ b/src/widgets/HexWidget.cpp @@ -122,7 +122,7 @@ HexWidget::HexWidget(QWidget *parent) : startAddress = 0ULL; cursor.address = 0ULL; - data = new MemoryData(); + data.reset(new MemoryData()); fetchData(); updateCursorMeta(); diff --git a/src/widgets/HexWidget.h b/src/widgets/HexWidget.h index afee3b49..cba04641 100644 --- a/src/widgets/HexWidget.h +++ b/src/widgets/HexWidget.h @@ -6,6 +6,7 @@ #include #include #include +#include struct BasicCursor { @@ -457,7 +458,7 @@ private: QAction *actionCopyAddress; QAction *actionSelectRange; - AbstractData *data; + std::unique_ptr data; }; #endif // HEXWIDGET_H diff --git a/src/widgets/RegisterRefsWidget.cpp b/src/widgets/RegisterRefsWidget.cpp index 9c3c437d..a905bca6 100644 --- a/src/widgets/RegisterRefsWidget.cpp +++ b/src/widgets/RegisterRefsWidget.cpp @@ -118,8 +118,8 @@ RegisterRefsWidget::RegisterRefsWidget(MainWindow *main, QAction *action) : ui->registerRefTreeView->setModel(registerRefProxyModel); ui->registerRefTreeView->sortByColumn(RegisterRefModel::RegColumn, Qt::AscendingOrder); - actionCopyValue = new QAction(tr("Copy register value")); - actionCopyRef = new QAction(tr("Copy register reference")); + actionCopyValue = new QAction(tr("Copy register value"), this); + actionCopyRef = new QAction(tr("Copy register reference"), this); refreshDeferrer = createRefreshDeferrer([this](){ refreshRegisterRef(); diff --git a/src/widgets/SectionsWidget.cpp b/src/widgets/SectionsWidget.cpp index a15b7266..30533aa3 100644 --- a/src/widgets/SectionsWidget.cpp +++ b/src/widgets/SectionsWidget.cpp @@ -321,8 +321,8 @@ void SectionsWidget::updateToggle() AbstractAddrDock::AbstractAddrDock(SectionsModel *model, QWidget *parent) : QDockWidget(parent), - addrDockScene(new AddrDockScene), - graphicsView(new QGraphicsView) + addrDockScene(new AddrDockScene(this)), + graphicsView(new QGraphicsView(this)) { graphicsView->setScene(addrDockScene); setWidget(graphicsView); diff --git a/src/widgets/StackWidget.cpp b/src/widgets/StackWidget.cpp index ae61096b..68bb5877 100644 --- a/src/widgets/StackWidget.cpp +++ b/src/widgets/StackWidget.cpp @@ -25,8 +25,8 @@ StackWidget::StackWidget(MainWindow *main, QAction *action) : viewStack->setHorizontalScrollMode(QAbstractItemView::ScrollPerPixel); ui->verticalLayout->addWidget(viewStack); - seekAction = new QAction(tr("Seek to this offset")); - editAction = new QAction(tr("Edit stack value...")); + seekAction = new QAction(tr("Seek to this offset"), this); + editAction = new QAction(tr("Edit stack value..."), this); viewStack->setContextMenuPolicy(Qt::CustomContextMenu); refreshDeferrer = createRefreshDeferrer([this]() { diff --git a/src/widgets/VTablesWidget.cpp b/src/widgets/VTablesWidget.cpp index b15833af..f04d70c2 100644 --- a/src/widgets/VTablesWidget.cpp +++ b/src/widgets/VTablesWidget.cpp @@ -138,7 +138,7 @@ VTablesWidget::VTablesWidget(MainWindow *main, QAction *action) : tree->addStatusBar(ui->verticalLayout); model = new VTableModel(&vtables, this); - proxy = new VTableSortFilterProxyModel(model); + proxy = new VTableSortFilterProxyModel(model, this); ui->vTableTreeView->setModel(proxy); ui->vTableTreeView->sortByColumn(VTableModel::ADDRESS, Qt::AscendingOrder);