From 3b8bdb699580cf1f45e4a065c6cd3825bc8a2632 Mon Sep 17 00:00:00 2001
From: xarkes <antide.petit@gmail.com>
Date: Thu, 22 Feb 2018 19:51:02 +0100
Subject: [PATCH] Warnings removal

---
 src/utils/PythonAPI.cpp | 37 +++++++++++++++++--------------------
 1 file changed, 17 insertions(+), 20 deletions(-)

diff --git a/src/utils/PythonAPI.cpp b/src/utils/PythonAPI.cpp
index 2a09df45..157a8dfb 100644
--- a/src/utils/PythonAPI.cpp
+++ b/src/utils/PythonAPI.cpp
@@ -47,31 +47,28 @@ PyObject *PyInit_api()
 
 PyObject *api_internal_launch_ipykernel(PyObject *self, PyObject *args, PyObject *kw)
 {
+    Q_UNUSED(self);
+    Q_UNUSED(kw);
+
     QStringList argv;
+    PyObject *argvListObject;
 
+    if (!PyArg_ParseTuple(args, "O", &argvListObject)
+            || !PyList_Check(argvListObject))
     {
-        PyObject *argvListObject;
-
-        if (!PyArg_ParseTuple(args, "O", &argvListObject)
-                || !PyList_Check(argvListObject))
-        {
-            qWarning() << "Invalid args passed to api_internal_launch_ipykernel().";
-            return nullptr;
-        }
-
-        for (int i=0; i<PyList_Size(argvListObject); i++)
-        {
-            PyObject *o = PyList_GetItem(argvListObject, i);
-            QString s = QString::fromUtf8(PyUnicode_AsUTF8(o));
-            argv.append(s);
-        }
+        qWarning() << "Invalid args passed to api_internal_launch_ipykernel().";
+        return nullptr;
     }
 
+    for (int i = 0; i < PyList_Size(argvListObject); i++)
+    {
+        PyObject *o = PyList_GetItem(argvListObject, i);
+        QString s = QString::fromUtf8(PyUnicode_AsUTF8(o));
+        argv.append(s);
+    }
 
     PyThreadState *parentThreadState = PyThreadState_Get();
 
-    PyThreadState *threadState = Py_NewInterpreter();
-
     QFile moduleFile(":/python/cutter_ipykernel.py");
     moduleFile.open(QIODevice::ReadOnly);
     QByteArray moduleCode = moduleFile.readAll();
@@ -93,15 +90,15 @@ PyObject *api_internal_launch_ipykernel(PyObject *self, PyObject *args, PyObject
 
     auto launchFunc = PyObject_GetAttrString(cutterIPykernelModule, "launch_ipykernel");
 
-    PyObject *argvListObject = PyList_New(argv.size());
-    for (int i=0; i<argv.size(); i++)
+    argvListObject = PyList_New(argv.size());
+    for (int i = 0; i < argv.size(); i++)
     {
         QString s = argv[i];
         PyList_SetItem(argvListObject, i, PyUnicode_DecodeUTF8(s.toUtf8().constData(), s.length(), nullptr));
     }
 
-
     auto ipyKernel = PyObject_CallFunction(launchFunc, "O", argvListObject);
+    Q_UNUSED(ipyKernel);
 
     PyThreadState_Swap(parentThreadState);