ch0ic3/cutter
1
0
Fork 0
mirror of https://github.com/rizinorg/cutter.git synced 2025-01-31 00:35:05 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Removed stackptr because the result is meaningless (#1285)

Browse Source
This commit is contained in:
xarkes 2019-03-14 11:03:15 +01:00 committed by GitHub
parent ec62045336
commit 3b87389d07
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/common/Configuration.cpp
View File

@ -26,7 +26,6 @@ static const QHash<QString, QVariant> asmOptions = {
{ "asm.xrefs", false }, { "asm.xrefs", false },
{ "asm.indent", false }, { "asm.indent", false },
{ "asm.describe", false }, { "asm.describe", false },
{ "asm.stackptr", false },
{ "asm.slow", true }, { "asm.slow", true },
{ "asm.lines", true }, { "asm.lines", true },
{ "asm.lines.fcn", true }, { "asm.lines.fcn", true },

8
src/dialogs/preferences/AsmOptionsWidget.cpp
View File

@ -38,8 +38,6 @@ void AsmOptionsWidget::updateAsmOptionsFromVars()
qhelpers::setCheckedWithoutSignals(ui->xrefCheckBox, Config()->getConfigBool("asm.xrefs")); qhelpers::setCheckedWithoutSignals(ui->xrefCheckBox, Config()->getConfigBool("asm.xrefs"));
qhelpers::setCheckedWithoutSignals(ui->indentCheckBox, Config()->getConfigBool("asm.indent")); qhelpers::setCheckedWithoutSignals(ui->indentCheckBox, Config()->getConfigBool("asm.indent"));
qhelpers::setCheckedWithoutSignals(ui->describeCheckBox, Config()->getConfigBool("asm.describe")); qhelpers::setCheckedWithoutSignals(ui->describeCheckBox, Config()->getConfigBool("asm.describe"));
qhelpers::setCheckedWithoutSignals(ui->stackpointerCheckBox,
Config()->getConfigBool("asm.stackptr"));
qhelpers::setCheckedWithoutSignals(ui->slowCheckBox, Config()->getConfigBool("asm.slow")); qhelpers::setCheckedWithoutSignals(ui->slowCheckBox, Config()->getConfigBool("asm.slow"));
qhelpers::setCheckedWithoutSignals(ui->linesCheckBox, Config()->getConfigBool("asm.lines")); qhelpers::setCheckedWithoutSignals(ui->linesCheckBox, Config()->getConfigBool("asm.lines"));
qhelpers::setCheckedWithoutSignals(ui->fcnlinesCheckBox, Config()->getConfigBool("asm.lines.fcn")); qhelpers::setCheckedWithoutSignals(ui->fcnlinesCheckBox, Config()->getConfigBool("asm.lines.fcn"));
@ -156,12 +154,6 @@ void AsmOptionsWidget::on_describeCheckBox_toggled(bool checked)
triggerAsmOptionsChanged(); triggerAsmOptionsChanged();
} }
void AsmOptionsWidget::on_stackpointerCheckBox_toggled(bool checked)
{
Config()->setConfig("asm.stackptr", checked);
triggerAsmOptionsChanged();
}
void AsmOptionsWidget::on_slowCheckBox_toggled(bool checked) void AsmOptionsWidget::on_slowCheckBox_toggled(bool checked)
{ {
Config()->setConfig("asm.slow", checked); Config()->setConfig("asm.slow", checked);

1
src/dialogs/preferences/AsmOptionsWidget.h
View File

@ -38,7 +38,6 @@ private slots:
void on_xrefCheckBox_toggled(bool checked); void on_xrefCheckBox_toggled(bool checked);
void on_indentCheckBox_toggled(bool checked); void on_indentCheckBox_toggled(bool checked);
void on_describeCheckBox_toggled(bool checked); void on_describeCheckBox_toggled(bool checked);
void on_stackpointerCheckBox_toggled(bool checked);
void on_slowCheckBox_toggled(bool checked); void on_slowCheckBox_toggled(bool checked);
void on_linesCheckBox_toggled(bool checked); void on_linesCheckBox_toggled(bool checked);
void on_fcnlinesCheckBox_toggled(bool checked); void on_fcnlinesCheckBox_toggled(bool checked);

7
src/dialogs/preferences/AsmOptionsWidget.ui
View File

@ -204,13 +204,6 @@
<string>Metadata</string> <string>Metadata</string>
</attribute> </attribute>
<layout class="QVBoxLayout" name="verticalLayout_5"> <layout class="QVBoxLayout" name="verticalLayout_5">
<item>
<widget class="QCheckBox" name="stackpointerCheckBox">
<property name="text">
<string>Show stack pointer (asm.stackptr)</string>
</property>
</widget>
</item>
<item> <item>
<widget class="QCheckBox" name="slowCheckBox"> <widget class="QCheckBox" name="slowCheckBox">
<property name="text"> <property name="text">

3
src/widgets/FunctionsWidget.cpp
View File

@ -209,8 +209,7 @@ QVariant FunctionModel::data(const QModelIndex &index, int role) const
.set("asm.lines.fcn", false) .set("asm.lines.fcn", false)
.set("asm.lines.out", false) .set("asm.lines.out", false)
.set("asm.lines.bb", false) .set("asm.lines.bb", false)
.set("asm.bbline", false) .set("asm.bbline", false);
.set("asm.stackptr", false);
disassemblyLines = Core()->disassembleLines(function.offset, kMaxTooltipDisasmPreviewLines + 1); disassemblyLines = Core()->disassembleLines(function.offset, kMaxTooltipDisasmPreviewLines + 1);
} }