From 21ab0e2a9ef66a9215279af1372c021010eb13ff Mon Sep 17 00:00:00 2001 From: alexthesys Date: Tue, 7 Dec 2021 11:57:05 +0300 Subject: [PATCH] Convert if-block to early return --- src/widgets/HexWidget.cpp | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/widgets/HexWidget.cpp b/src/widgets/HexWidget.cpp index a3e0ae46..334176be 100644 --- a/src/widgets/HexWidget.cpp +++ b/src/widgets/HexWidget.cpp @@ -754,19 +754,20 @@ void HexWidget::w_writeBytes() const int offset = bytes.startsWith("\\x") ? 2 : 0; const int incr = offset + 2; const int bytes_size = qMin(bytes.size() / incr, size); - if (ok && bytes_size) { - uint8_t *buf = (uint8_t *)malloc(static_cast(bytes_size)); - if (!buf) { - return; - } - for (int i = 0, j = 0, sz = bytes.size(); i < sz; i += incr, j++) { - buf[j] = static_cast(bytes.mid(i + offset, 2).toInt(nullptr, 16)); - } - RzCoreLocked core(Core()); - rz_core_write_at(core, getLocationAddress(), buf, bytes_size); - free(buf); - refresh(); + if (!ok || !bytes_size) { + return; } + uint8_t *buf = (uint8_t *)malloc(static_cast(bytes_size)); + if (!buf) { + return; + } + for (int i = 0, j = 0, sz = bytes.size(); i < sz; i += incr, j++) { + buf[j] = static_cast(bytes.mid(i + offset, 2).toInt(nullptr, 16)); + } + RzCoreLocked core(Core()); + rz_core_write_at(core, getLocationAddress(), buf, bytes_size); + free(buf); + refresh(); } void HexWidget::w_writeZeros()