Tonis Tiigi
35fcb28a00
Clean up old TODOs
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-09-14 22:28:08 -07:00
Koichi Shiraishi
671ae38fb7
all: unify the specs-go package import alias to ocispecs
...
ocispecs means "O"pen "C"ontainer "I"nitiative image-spec/"specs"-go/v1
opencontainers /image-spec/specs-go/v1
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
2021-08-11 08:29:09 +09:00
Morlay
18b49fd7dc
refactor to use util/bklog instead of using logurs directly
...
Signed-off-by: Morlay <morlay.null@gmail.com>
2021-07-13 11:42:31 +08:00
Tonis Tiigi
3233c5275a
authprovider: handle eaccess on storing token seeds
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-07-08 21:37:03 -07:00
Yamazaki Masashi
8a4efe4de7
Remove meaningless encode
...
Signed-off-by: Yamazaki Masashi <masi19bw@gmail.com>
2021-07-08 00:01:42 +09:00
Tõnis Tiigi
f5c34a05b8
Merge pull request #2047 from thaJeztah/improve_errors
...
Remove duplicate "not found" from some error messages
2021-07-01 21:36:33 -07:00
Akihiro Suda
be8ab28a0a
Merge pull request #2081 from tonistiigi/local-differ-none
...
Allow none differ on local source to avoid false Dockerfile matches
2021-07-01 09:42:24 +09:00
Tonis Tiigi
ee39f5dd68
dockerfile: use none differ for dockerfile/dockerignore
...
This avoids wrong metadata matches on small files
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-29 16:17:08 -07:00
Tonis Tiigi
7489cc8be0
vendor: update opentelemetry to 1.0.0-rc
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-19 10:02:26 -07:00
Tonis Tiigi
b10f25944b
correctly validate span from context
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-15 21:11:27 -07:00
Tonis Tiigi
9717e62b78
session: avoid tracing health checkpoint
...
Upstream fixes needed for cleaner solution
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-15 21:11:27 -07:00
Tonis Tiigi
8f50bae3f1
replace opentracing with opentelemetry tracers
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-15 21:11:27 -07:00
Tonis Tiigi
baa4fcdb0f
add differ support for local source
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-11 21:15:07 -07:00
Akihiro Suda
59d2f76e5e
Merge pull request #2161 from tonistiigi/auth-context
...
session: make sure all token request keep correct context
2021-06-11 14:38:40 +09:00
Tonis Tiigi
ce27b7e638
filesync: ensure sendclose is always called
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-08 21:19:10 -07:00
Tonis Tiigi
53e7116197
session: make sure all token request keep correct context
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-08 21:17:35 -07:00
Siebe Schaap
c9a5f8893f
Fix regular expression to test for Windows named pipe in SSH agent path; allowed backslashes in host.
...
Signed-off-by: Siebe Schaap <siebe@digibites.nl>
2021-05-27 20:40:43 +02:00
Siebe Schaap
f3bdb4a784
Rename SSH agent forwarding helper parsePlatformSocketPath() to getWindowsPipeDialer().
...
Signed-off-by: Siebe Schaap <siebe@digibites.nl>
2021-05-27 20:40:43 +02:00
Siebe Schaap
146ea468c9
Update Windows named pipe handling for SSH forwarding to use x/sys/windows rather than syscall.
...
Signed-off-by: Siebe Schaap <siebe@digibites.nl>
2021-05-27 20:40:43 +02:00
Siebe Schaap
dbbe65baec
Update SSH agent socket handling to support Windows OpenSSH using named pipes.
...
Signed-off-by: Siebe Schaap <siebe@digibites.nl>
2021-05-27 20:40:43 +02:00
Charles Korn
8854bbc431
Fix https://github.com/moby/buildkit/issues/2109 .
...
Signed-off-by: Charles Korn <me@charleskorn.com>
2021-05-26 09:50:15 +10:00
Tonis Tiigi
6157418c76
authprovider: allow errors on seed unmarshal
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-03-29 22:14:41 -07:00
Sebastiaan van Stijn
b81b56e000
Remove duplicate "not found" from some error messages
...
I noticed this when building a Dockerfile that failed because a file didn't
exist, so went through error messages that looked like they had a duplicate
"not found" in the output;
[+] Building 0.9s (6/9)
=> [internal] load build definition from Dockerfile 0.2s
=> => transferring dockerfile: 306B 0.0s
=> [internal] load .dockerignore 0.1s
=> => transferring context: 2B 0.0s
=> [internal] load metadata for docker.io/library/alpine:latest 0.0s
=> CACHED [1/5] FROM docker.io/library/alpine 0.0s
=> [internal] load build context 0.6s
=> => transferring context: 701B 0.5s
=> ERROR [2/5] ADD no-such-file.txt / 0.0s
------
> [2/5] ADD no-such-file.txt /:
------
failed to compute cache key: "/no-such-file.txt" not found: not found
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-03-29 13:17:06 +02:00
Akihiro Suda
13ea18ad08
vendor containerd (requred for rootless overlayfs on kernel 5.11)
...
Required for rootless overlayfs on kernel 5.11
https://github.com/containerd/containerd/pull/5076
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2021-03-10 13:51:27 +09:00
Tonis Tiigi
b7510f7487
authprovider: allow readonly config dir
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-10-21 22:12:51 -07:00
Tõnis Tiigi
4177e7ca28
Merge pull request #1660 from tonistiigi/token-fetch
...
auth: fetch tokens from client side
2020-10-12 16:13:19 -07:00
Ximo Guanter
da8ebc8a39
Make HTTP/2 authority pseudo-header spec-compliant
...
Signed-off-by: Ximo Guanter <ximo.guanter@gmail.com>
2020-10-03 22:58:21 +02:00
Nick Santos
399dacf410
sshprovider: on Windows, ModeSocket might not be set on the ssh socket
...
Fixes https://github.com/moby/buildkit/issues/914
Signed-off-by: Nick Santos <nicholas.j.santos@gmail.com>
2020-09-22 19:42:38 -04:00
Tonis Tiigi
1f94445456
auth: fetch tokens from client side
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-09-15 13:40:30 -07:00
Sebastiaan van Stijn
f0e241905e
secretsprovider.NewStore() simplify env handling
...
The `doesEnvExist()` utility was copied from the classic builder,
and was developed when `os.LookupEnv()` did not yet exist.
Now that it's available, replace our custom implementation in
favor of Golang's function.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-08-14 17:27:41 +02:00
Tonis Tiigi
b474dbf55f
resolver: clean up unused resolver pool
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-08-13 17:27:18 -07:00
Tonis Tiigi
f1cd79bf65
resolver: add better pooling and custom authenticator
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-08-13 17:27:11 -07:00
Tonis Tiigi
bd3354fea3
session: avoid deprecated grpc.Stream type
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-07-19 09:28:36 -07:00
Tonis Tiigi
57a88b0afb
lint: add misspell and unused
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-07-18 08:13:57 -07:00
Edgar Lee
488130002a
Merge pull request #1551 from tonistiigi/session-group
...
session: track sessions with a group construct
2020-07-08 16:37:07 -07:00
Tonis Tiigi
2e9987ad16
session: track sessions with a group construct
...
Avoid hidden session passing and allow one session to drop when
multiple builds share a vertex.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-07-05 00:15:25 -07:00
Tonis Tiigi
fdebe4c6b2
secrets: reuse constant on error message
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-06-18 09:19:23 -07:00
Tonis Tiigi
0ab180019d
secrets: remove file specifics from variable names
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-06-17 12:33:15 -07:00
Tonis Tiigi
64e64e424d
secrets: allow providing secrets with env
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-06-16 17:12:39 -07:00
Sebastiaan van Stijn
3ddd1fc23c
Fix goimports linting
...
```
[5/5] RUN --mount=target=/go/src/github.com/moby/buildkit gometalinter ...
0.435 util/rootless/specconv/specconv_linux.go:1:⚠️ file is not goimported (goimports)
1.320 cache/manager.go:1:⚠️ file is not goimported (goimports)
1.335 cache/manager_test.go:1:⚠️ file is not goimported (goimports)
1.337 cache/migrate_v2.go:1:⚠️ file is not goimported (goimports)
1.342 cache/refs.go:1:⚠️ file is not goimported (goimports)
1.454 cache/remotecache/registry/registry.go:1:⚠️ file is not goimported (goimports)
2.285 cmd/buildctl/build.go:1:⚠️ file is not goimported (goimports)
3.082 executor/oci/user.go:1:⚠️ file is not goimported (goimports)
4.333 session/content/content_test.go:1:⚠️ file is not goimported (goimports)
4.614 snapshot/containerd/content.go:1:⚠️ file is not goimported (goimports)
4.721 solver/errdefs/vertex.go:1:⚠️ file is not goimported (goimports)
6.066 util/network/cniprovider/cni.go:1:⚠️ file is not goimported (goimports)
ERROR: executor failed running [/bin/sh -c gometalinter --config=gometalinter.json ./...]: buildkit-runc did not terminate successfully
```
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2020-05-13 17:38:56 +02:00
Tonis Tiigi
6bd2d45527
filesync: avoid ignoring close error
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-05-08 17:48:56 -07:00
Tonis Tiigi
c78e875977
remove last instances of errors cause
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-24 11:25:53 -07:00
Tonis Tiigi
725f5e1207
grpc interceptors for errors
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-22 18:31:32 -07:00
Tonis Tiigi
37b8832d00
upgrade errors checks to Is()
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-18 22:53:38 -07:00
Akihiro Suda
7b579cdb98
vendor: update containerd (and various packages)
...
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-02-28 10:24:10 +09:00
Troels Liebe Bentsen
9c70fb9927
Disallow Extensions for now
...
Signed-off-by: Troels Liebe Bentsen <tlb@nversion.dk>
2019-11-21 21:57:04 +01:00
Troels Liebe Bentsen
4e7904f37e
Inherit extended agent so we get modern sign hashes
...
Signed-off-by: Troels Liebe Bentsen <tlb@nversion.dk>
2019-11-20 00:15:51 +01:00
Tonis Tiigi
307bdc3c3d
exec: fix mount options on userns remapping
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2019-10-29 14:20:40 -07:00
Tonis Tiigi
bc3a1eefdd
session: release forwarded ssh socket connection per connection
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2019-08-26 15:34:55 -07:00
Tonis Tiigi
96b6a28312
exporter: allow oci exporters visibility to response metadata
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2019-07-31 10:21:19 -07:00