This updates all occurrences of Go 1.13 to Go 1.16; also updated
the code that's used to redact credentials in URLs to use the Go
implementation.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This patch updates the script and Dockerfile to prevent issues when using go
modules.
The first change is to use a plain `git clone` instead of `go get -d` to download
the source. While (like "pre go-modules") `go get -d` won't *build* the binaries
when go modules are used, it *will* use go modules to download the package
(and dependencies); as a result:
- no git repository will be cloned in gopath
- go modules will be downloaded for "master" (not the version that we specify
to build)
Note: Once we update to Go 1.16, this script could be updated to use `go install <repo>@version`
The second change is an update to the `update-generated-files` script to detect
the correct version of google/protobuf to use from the `go.mod`'s `replace` rule,
to make sure we generate (and verify) using the correct version.
The Dockerfile was also updated to update the default versions specified in the
PROTOBUF_VERSION and GOGO_VERSION build-args (although not strictly necessary).
Regenerating the files with this version resulted in a minor formatting change.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
By default, Ubuntu or Debian based "apt" or "apt-get" system installs recommended but not suggested packages .
By passing "--no-install-recommends" option, the user lets apt-get know not to consider recommended packages as a dependency to install.
This results in smaller downloads and installation of packages .
Refer to blog at [Ubuntu Blog](https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends) .
Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
Looks like due to a bug in Dockerfile frontend, only the BUILDKITD_TAGS
build arg was taken into account, not the env var.
Signed-off-by: Tibor Vass <tibor@docker.com>
This is not meant to produce any working Windows binary of buildkitd.
Purpose is to catch compile failures on windows early.
Signed-off-by: Tibor Vass <tibor@docker.com>
This makes setting build-tags more convenient;
make binaries BUILDKITD_TAGS="$(cat frontend/dockerfile/release/experimental/tags)"
Based-on-patch-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Run this command:
`docker build --tag davetest -f ./hack/dockerfiles/test.Dockerfile --target integration-tests`
Will throw this error message:
`Executing busybox-1.29.3-r10.trigger
OK: 184 MiB in 43 packages
Creating mailbox file: No such file or directory`
Not impact functionality but a little bit annoying.
Signed-off-by: Dave Chen <dave.chen@arm.com>
Including critical security fix for `runc run --no-pivot` (unlikely to
affect BuildKit): https://github.com/opencontainers/runc/pull/1962
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
shadow-maint/shadow@52c081b (20181028) caused a regression that results in
`newuidmap: open of uid_map failed: Permission denied`.
The regression was fixed in shadow-maint/shadow@59c2dab (20181125).
Note that docker.io/moby/buildkit images are not affected by the
regression, because we forgot to update the rootless-base-external
image when we updated the shadow package before.
Related: genuinetools/img#191genuinetools/img#196
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Tõnis Tiigi
Sebastiaan van Stijn
CrazyMax
Pratik Raj
Akihiro Suda
Derek McGowan
Tibor Vass
Akihiro Suda
Dave Chen
Patrick Van Stee
Kunal Kushwaha
Alice Frosi