78e88560e1
Merge pull request #2387 from tonistiigi/gha-fixes
...
fixes for github actions cache
2021-10-04 08:53:08 -07:00
c13f5de2fb
solver: make sure previous error gets reset
...
This happens for example when cache loading fails
but then fallback step execution succeeds.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-10-02 14:52:14 -07:00
e76cfcfa22
don't cast Value when pipe is errored
...
Signed-off-by: Maxime Lagresle <maxime@angel.co>
2021-10-02 11:08:27 +02:00
42aefeb694
Merge pull request #2384 from crazy-max/shmsize
...
Add support for shm size
2021-10-01 18:16:51 +02:00
6094339341
Add support for shm size
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2021-10-01 16:07:29 +02:00
b6d092d81e
return an error instead of panicking when failing to get edge
...
Signed-off-by: Maxime Lagresle <maxime@angel.co>
2021-09-30 14:17:07 +02:00
44891f4cb9
Merge pull request #2369 from tonistiigi/resolver-timeout-fixes
...
resolver timeout fixes
2021-09-21 14:29:01 +09:00
161b581e71
solver: increase timeout for job registration
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-09-18 21:28:45 -07:00
5fcc94454f
Generate and embed build sources
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2021-09-18 01:39:35 +02:00
a9f1980ebb
Refactor cache metadata interface.
...
There are a few goals with this refactor:
1. Remove external access to fields that no longer make sense and/or
won't make sense soon due to other potential changes. For example,
there can now be multiple blobs associated with a ref (for different
compression types), so the fact that you could access the "Blob"
field from the Info method on Ref incorrectly implied there was just
a single blob for the ref. This is on top of the fact that there is
no need for external access to blob digests.
2. Centralize use of cache metadata inside the cache package.
Previously, many parts of the code outside the cache package could
obtain the bolt storage item for any ref and read/write it directly.
This made it hard to understand what fields are used and when. Now,
the Metadata method has been removed from the Ref interface and
replaced with getters+setters for metadata fields we want to expose
outside the package, which makes it much easier to track and
understand. Similar changes have been made to the metadata search
interface.
3. Use a consistent getter+setter interface for metadata, replacing
the mix of interfaces like Metadata(), Size(), Info() and other
inconsistencies.
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
2021-08-25 19:15:09 +00:00
808091a4e1
solver: include cachemap index in flightcontrol.
...
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
2021-08-16 17:26:36 +00:00
0b683eb1ff
add missing ExtraHosts to gateway exec
...
Also adding tests for ExtraHosts and NetMode via gateway exec
Signed-off-by: Cory Bennett <cbennett@netflix.com>
2021-08-15 02:51:37 +00:00
671ae38fb7
all: unify the specs-go package import alias to ocispecs
...
ocispecs means "O"pen "C"ontainer "I"nitiative image-spec/"specs"-go/v1
opencontainers /image-spec/specs-go/v1
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
2021-08-11 08:29:09 +09:00
d3cd28f59f
Merge pull request #2249 from claudiubelu/fixes-missing-passwd-file
...
Skips getting UID/GUID if passwd/group file is not found
2021-07-13 13:57:11 -07:00
449d010a72
Skips getting UID/GUID if passwd/group file is not found
...
When running a WORKDIR instruction, buildkit will create that folder
and chown it to the currently set user. For this, it will try to read
the /etc/passwd file to get the proper UID, and if that user is not
found in the file, the root user will be considered as the owner.
However, Windows image do not have that file, which will result in
an error while building the image. We can consider not finding
the /etc/passwd file as the same as not finding the user in the file,
which would solve this issue.
Signed-off-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
2021-07-13 19:06:33 +00:00
18b49fd7dc
refactor to use util/bklog instead of using logurs directly
...
Signed-off-by: Morlay <morlay.null@gmail.com>
2021-07-13 11:42:31 +08:00
b1c80cf0ab
caps: add cap for gha cache backend
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-07-09 20:49:26 -07:00
9df59934cd
Merge pull request #2218 from tonistiigi/error-suggest
...
dockerfile: add suggestions to how to fix certain errors
2021-07-07 10:52:07 -07:00
b055d2d55c
Merge pull request #2057 from ktock/export-compression
...
exporter: Enable to specify the compression type for all layers of the finally exported image
2021-07-06 21:52:36 -07:00
3152eab58f
Enable to forcefully specify compression type
...
Signed-off-by: ktock <ktokunaga.mail@gmail.com>
2021-07-07 12:00:06 +09:00
4e4152832c
dockerfile: remove unnecessary error wrappings
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-07-02 17:29:32 -07:00
1a7543a105
Merge pull request #2163 from tonistiigi/detect-otel-env
2021-07-03 01:01:34 +09:00
3c4f73768b
Merge pull request #2217 from sipsma/fileop-ref-leak
...
Fix ref leak if fileop ref fails to mount.
2021-07-01 17:38:55 -07:00
f3604724d4
Fix ref leak if fileop ref fails to mount.
...
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
2021-07-01 23:38:13 +00:00
7d386663ec
Merge pull request #2216 from sipsma/cleancache
...
Remove unneeded Finalize method from ImmutableRef.
2021-07-01 16:35:33 -07:00
b85ef15689
Remove unneeded Finalize method from ImmutableRef.
...
Finalize was only used outside the cache package in one place, which
called it with the commit arg set to false. The code path followed
when commit==false turned out to essentially be a no-op because
it set "retain cache" to true if it was already set to true.
It was thus safe to remove the only external call to it and remove it
from the interface. This should be helpful for future efforts to
simplify the equal{Mutable,Immutable} fields in cacheRecord, which exist
due to the "lazy commit" feature that Finalize is tied into.
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
2021-07-01 17:54:59 +00:00
8d70a9e098
Merge pull request #2215 from tonistiigi/improve-errors
...
Improve build errors and remove useless grpc prefix
2021-07-01 14:33:40 +09:00
a27d7c3d81
exec: improve error message on exec errors
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-30 21:10:37 -07:00
be8ab28a0a
Merge pull request #2081 from tonistiigi/local-differ-none
...
Allow none differ on local source to avoid false Dockerfile matches
2021-07-01 09:42:24 +09:00
b1d441b175
[ #2112 ] progress.FromContext returns a writer factory
...
this allows progress.Controller to manage the writer lifecycle
Signed-off-by: Cory Bennett <cbennett@netflix.com>
2021-06-28 18:58:29 +00:00
1d0597e85a
handle unconfigured spans without errors
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-22 08:27:35 -07:00
c773a215c1
integration: add common context base to all integration tests
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-18 20:49:49 -07:00
c325f89fa1
replace uses of deprecated containerd/sys.RunningInUserNS()
...
This utility was moved to a separate package, which has no dependencies.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-06-18 11:14:26 +02:00
b10f25944b
correctly validate span from context
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-15 21:11:27 -07:00
8f50bae3f1
replace opentracing with opentelemetry tracers
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-15 21:11:27 -07:00
a7b155e30c
llb: don't allow content diff for now
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-11 21:15:10 -07:00
baa4fcdb0f
add differ support for local source
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-06-11 21:15:07 -07:00
817955dc8d
Merge pull request #2116 from tonistiigi/git-subdir
...
git: support subdir component
2021-06-08 14:27:50 +09:00
8df5671844
Merge pull request #2082 from aaronlehmann/copy-include-exclude
...
Add IncludePatterns and ExcludePatterns options for Copy
2021-06-01 12:47:13 -07:00
e51dbe9fae
Merge pull request #2123 from hinshun/abs-mountpoint
...
Transform relative mountpoints for exec mounts in the executor
2021-05-26 19:37:52 -07:00
b27fc6169b
Combine include/exclude caps into a single cap
...
Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
2021-05-26 13:48:03 -07:00
626744c9e7
Cache awareness of IncludePatterns/ExcludePatterns
...
Consider IncludePatterns and ExcludePattern when calculating content
hashes.
Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
2021-05-26 13:48:03 -07:00
b545c281c1
Add capabilities for copy include/exclude patterns
...
Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
2021-05-26 13:48:03 -07:00
7660af2f1d
Add IncludePatterns and ExcludePatterns options for Copy
...
Allow include and exclude patterns to be specified for the "copy" op,
similarly to "local".
Depends on https://github.com/tonistiigi/fsutil/pull/101
Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
2021-05-26 13:48:03 -07:00
9aeed7b193
Transform relative mountpoints for exec mounts in the executor
...
Signed-off-by: Edgar Lee <edgarl@netflix.com>
2021-05-20 15:17:27 -07:00
3bdb6b5159
git: support subdir component
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2021-05-19 22:13:04 -07:00
60d38f972c
Move config under worker config. Add new integration test to GHA matrix.
...
Signed-off-by: Vlad A. Ionescu <vladaionescu@users.noreply.github.com>
2021-05-13 14:55:36 +03:00
b3cf7c43cf
Switch to Acquire API.
...
Signed-off-by: Vlad A. Ionescu <vladaionescu@users.noreply.github.com>
2021-05-12 13:41:33 +03:00
489e17aea9
Add a configuration item to limit parallelism.
...
Signed-off-by: Vlad A. Ionescu <vladaionescu@users.noreply.github.com>
2021-05-10 15:47:59 +03:00
f113b49307
Merge pull request #2086 from thaJeztah/add_all_proxy
...
Add "ALL_PROXY" to list of default args / proxy env-vars
2021-04-26 09:09:44 -07:00
Tõnis Tiigi
Maxime Lagresle
CrazyMax
CrazyMax
Akihiro Suda
Erik Sipsma
Cory Bennett
Koichi Shiraishi
Claudiu Belu
Morlay
ktock
Akihiro Suda
Sebastiaan van Stijn
Aaron Lehmann
Edgar Lee
Vlad A. Ionescu