c524709f4a
buildkitd: add config file support
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-30 16:11:55 -07:00
3eda0516da
dockerfile: allow overriding copy image
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-30 13:21:52 -07:00
9d1b0e6b31
Merge pull request #597 from tonistiigi/graceful-scheduler-errors
...
solver: gracefully handle scheduler bugs
2018-08-30 10:56:39 -07:00
7e971435a4
Merge pull request #590 from tonistiigi/fix-panic
...
solver: fix panic on creating input requests
2018-08-30 10:54:41 -07:00
45aedff363
Merge pull request #571 from ijc/solver-def-and-frontend-mutually-exclusive
...
solver: Don't solve both the provided Defininiton & frontend
2018-08-30 10:10:52 -07:00
c9711fcc26
Merge pull request #574 from ijc/return-frontend-metadata
...
Allow some Metadata to be return from frontend to the control client
2018-08-30 10:08:51 -07:00
755bf5387e
Moved some subtests into `t.Run` blocks.
...
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-30 16:28:19 +01:00
3db7441e06
clarify naming in testFrontendImageNaming
...
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-30 15:59:12 +01:00
8d114533c2
exports: require caller to request frontend-based naming, by passing name of `%s`.
...
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-30 15:59:06 +01:00
53921cf110
llbBridfgeForwarder: Drop refs as they are released in `Discard`.
...
This makes it safe(r) for `Discard` to be called more than once.
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-30 15:23:49 +01:00
b558d75d3a
Consistently protect `llbBridgeForwarder.refs` with mutex
...
Most accesses to this map are protected. Add the missing locks (some of which
are in code paths where we wouldn't normally expect concurrent accesses, but
better to be safe).
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-30 15:03:29 +01:00
59391d1647
clientside-frontend: release non-result refs after completion
...
Tests such as TestNoSnapshotLeak were failing in client mode (e.g. using #522 )
because we weren't releasing the intermediate refs.
Resolve this by refactoring the existing code which frees the intermediate refs
from `gatewayFrontend.Solve` into a method on `llbBridgeForwarder` and as well
as the original site also call from the solver when the top-level solve (in
clientside frontend mode) completes. The original call (which is via a defer)
could likely sensibly be moved either earlier or later if desired but leave it
here it is to minimise the scope of the change.
The previous code used the `retErr` named return but the code between that
point and the end of the function already ensured that `lbf.err` is the same as
`retErr`, thus the only change in the code which has moved is
`s/retErr/lbf.err/`. Note that the `res` named return was previously unused by
name.
Fixes #581 .
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-30 14:54:50 +01:00
cc83b34572
solver: remove redundant conditional
...
There is now no way to reach this point with the test being false.
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-30 14:01:27 +01:00
ab7928edff
solver: error if both Definition and Frontend are given.
...
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-30 13:59:26 +01:00
153ed12eb9
Merge pull request #591 from dmcgowan/update-containerd-1.2
...
Update containerd vendor
2018-08-29 13:45:29 -07:00
17e6416706
Merge pull request #504 from kunalkushwaha/no-console
...
--no-progress replaced with --progress
2018-08-29 13:44:51 -07:00
0d68543b1e
solver: mark build failed instead of panicking on scheduler error
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-29 11:10:05 -07:00
c77b6d4759
solver: gracefully handle bugs leaving incoming requests open
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-28 17:07:50 -07:00
a384bccbbf
solver: add test for input request deadlock
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-28 16:47:31 -07:00
6daf696f04
dockerfile: add required option for secrets
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-28 16:18:08 -07:00
279a144686
Update containerd vendor
...
Picks up platform changes
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2018-08-28 14:26:14 -07:00
64ff38f163
client: reset user ID for synced dirs
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-28 14:22:22 -07:00
94cc96a0ed
Merge pull request #592 from tonistiigi/run-entrypoint
...
dockerfile: never use entrypoint for run commands
2018-08-28 06:52:23 -07:00
38569b9b9a
dockerfile: never use entrypoint for run commands
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-27 17:48:18 -07:00
ee82ffe538
solver: correct dep key conditions
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-27 16:18:23 -07:00
1127380f91
solver: allow enabling debugger on runtime
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-27 16:16:35 -07:00
23904e6ffa
solver: add test for input request deadlock
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-27 16:12:50 -07:00
9d0570c6aa
Merge pull request #588 from tonistiigi/meta-quotes-fix
...
dockerfile: fix quoting of meta args
2018-08-28 06:24:07 +09:00
4963ed7ea4
dockerfile: fix quoting of meta args
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-08-27 09:39:55 -07:00
49c9f75275
--no-progress replaced with --progress
...
this make buildctl build output options same as moby.
Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
2018-08-27 11:23:15 +09:00
277037a77f
Merge pull request #587 from AkihiroSuda/update-containerd-113
...
update containerd (binary: v1.1.3, library: Aug 23, 2018)
2018-08-24 20:29:28 -07:00
557bba11c9
containerd: disable CRI plugin
...
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2018-08-23 18:14:57 +09:00
b90615d34d
integration: print containerd logs on failure
...
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2018-08-23 18:14:57 +09:00
decb27618b
containerd: set timeout explicitly (60s)
...
The contained default value was shortened from 60s to 10s in containerd/containerd#2554
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2018-08-23 18:14:57 +09:00
2fa4c37854
update containerd (binary: v1.1.3, library: Aug 23, 2018)
...
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2018-08-23 16:21:55 +09:00
f71f4b63a2
Merge pull request #577 from tiborvass/source-resolvemode-stringer
...
source: Have ResolveMode implement fmt.Stringer interface
2018-08-23 15:33:34 +09:00
e1cd06ad6b
Merge pull request #584 from crosbymichael/networking
...
Refactor networking with ns paths
2018-08-23 12:10:32 +09:00
2f0c048493
network: move handling of NetMode_UNSET to Default()
...
This allows other workers to implement their own behavior for NetMode_UNSET
Signed-off-by: Tibor Vass <tibor@docker.com>
2018-08-23 00:06:06 +00:00
49906c6292
Merge pull request #576 from ijc/bump-gogo-googleapis
...
Bump github.com/gogo/googleapis to b23578765ee5
2018-08-21 13:06:00 -07:00
b97bc71adb
Refactor networking with ns paths
...
This fixes the issues where buildkit and callers do not have to be a
subpreaper in order to use networking. I can add CNI provider later,
with a hidden sub command to create a new network namespace and bind
mount it to buildkit's state dir.
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
2018-08-21 13:37:47 -04:00
e8c7acc99c
Merge pull request #578 from dmcgowan/update-containerd-1.2
...
Update containerd v1.2 beta
2018-08-18 20:55:40 -07:00
110c829d15
Update containerd v1.2 beta
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2018-08-17 13:12:02 -07:00
6644e1b0da
source: Have ResolveMode implement fmt.Stringer interface
...
Out of the two ResolveMode types in buildkit, only the lower-level one in client/llb
had a String() method. This patch makes the ResolveMode type from the source package
also have a String() method.
Signed-off-by: Tibor Vass <tibor@docker.com>
2018-08-17 14:33:34 +00:00
6398c26ec7
Bump github.com/gogo/googleapis to b23578765ee5
...
This is the next commit and merely adds a LICENSE file.
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-17 14:22:52 +01:00
fa39d134ee
exporters: allow frontend control of the exported image name
...
Returning a metadata item named "image.name" will set the name to use.
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-17 13:20:36 +01:00
fdf13cf96e
Allow some Metadata to be return from frontend to the control client
...
Propagate anything in the `frontend.*` namespace from the `frontend.Result`
into the `client.SolveResponse`.
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-17 12:45:21 +01:00
af46188e9b
Merge pull request #533 from ijc/client-gateway
...
access gateway API from client
2018-08-17 05:12:23 +09:00
250401ffc4
Merge pull request #560 from tonistiigi/nethost
...
solver: net host with basic entitlements support
2018-08-17 05:11:13 +09:00
e05be2fd2c
solver: Don't solve both the provided Defininiton & frontend
...
This seems wasteful. I think there is no side-effects of the Load+Build of the
definition which would make a difference to the frontend solve.
Note that this changes the presedence of the actual result, previously the
frontend result would overwrite the definition's one, while now the frontend
would not be run.
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-15 16:20:02 +01:00
5383270387
examples: demonstrate client-side Build() interface.
...
Adds an option/envvar to `examples/build-using-dockerfile` which uses a client
side instance of the dockerfile frontend.
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-08-14 11:50:08 +01:00
Tonis Tiigi
Tibor Vass
Ian Campbell
Derek McGowan
Akihiro Suda
Kunal Kushwaha
Akihiro Suda
Tibor Vass
Michael Crosby