JohnHammond
/
buildkit
mirror of https://github.com/JohnHammond/buildkit.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,894 Commits
7 Branches
72 Tags
26 MiB
Commit Graph

356 Commits (23af9dcb86ab24a66bef2534933eb62add91815f)

Author SHA1 Message Date
Wei Fu 9f063f6b61 resolver: disable http2 for pushing 
The golang net/http package uses http2 client to serve https by default,
if let Transport.TLSNextProto is nil. And net/http package doesn't
provide tunnable value for http2 flow control which will limit push
performance.

Before this commit, use GODEBUG="http2debug=1" buildkitd to pushing
one image from dockerfile like

```
$ about 700MB
FROM scratch
ADD ./golang-1.13.0-stretch.tar.gzip /
```

and use ifstat to monitor network interface and found that

```
$ ifstat -i enp0s3
      enp0s3
 KB/s in  KB/s out
    0.47      0.67
    0.44      0.51
   19.72     11.56
   62.25   2184.41
   96.34   3514.28
   93.89   3508.31
   95.41   3515.53
   91.61   3433.22
   95.82   3579.68
   90.36   3388.89
   93.64   3513.03
   93.32   3478.04
   ...

$ log from buildkitd
2020/03/31 17:40:33 http2: Transport received WINDOW_UPDATE stream=11 len=4 incr=32768
2020/03/31 17:40:33 http2: Transport received WINDOW_UPDATE len=4 (conn) incr=271
2020/03/31 17:40:33 http2: Transport received WINDOW_UPDATE stream=11 len=4 incr=271
2020/03/31 17:40:33 http2: Transport received WINDOW_UPDATE len=4 (conn) incr=32496
2020/03/31 17:40:33 http2: Transport received WINDOW_UPDATE stream=11 len=4 incr=32496
...
```

The registry will update window size of flow control when receives each
frame data. The sender need wait for receiver update the window size if
the sender runs out of buffer of flow control. But the increase value
for buffer by WINDOW_UPDATE frame is too small and slow which impacts
push performance.

Before net/http package provides tunnable value for flow control, we
should disable http2 for https request.

And with this commit, the performance will be better like:

```
$ ifstat -i enp0s3
      enp0s3
 KB/s in  KB/s out
    0.56      0.61
   16.13      5.55
   18.89      9.23
  218.84   7832.80
  338.56  13074.04
  302.39  11713.83
  231.62   8964.60
  356.50  13504.02
  298.14  11401.81
  311.24  11783.26
  333.01  12710.17
  329.64  12630.40
  305.87  11662.04
  292.53  11118.04
```

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2020-03-31 17:59:13 +08:00
Tonis Tiigi 56f76a5621 resolver: support self signed certificates 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2020-03-16 22:09:27 -07:00
Tõnis Tiigi b9ef26d15f
Merge pull request #1403 from Container-Projects/master 
optimization debian package manager tweaks
 2020-03-11 17:34:11 -07:00
Pratik Raj 2910de68b1 optimization debian package manager tweaks 
By default, Ubuntu or Debian based "apt" or "apt-get" system installs recommended but not suggested packages .

By passing "--no-install-recommends" option, the user lets apt-get know not to consider recommended packages as a dependency to install.

This results in smaller downloads and installation of packages .

Refer to blog at [Ubuntu Blog](https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends) .

Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
 2020-03-11 15:27:54 +05:30
Tonis Tiigi 2c3cf11fde resolver: update to new registryhosts based config 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2020-03-05 19:56:43 -08:00
Akihiro Suda 7b579cdb98 vendor: update containerd (and various packages) 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 2020-02-28 10:24:10 +09:00
Tonis Tiigi d1458a6587 update supported platforms without restart 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2020-02-26 08:15:42 -08:00
Tonis Tiigi a60ecfa4ae vendor: restore dependency versions 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2020-02-24 17:31:01 -08:00
Zach Badgett 1efe7b145d Fix docker dependencies 
Signed-off-by: Zach Badgett <zach.badgett@gmail.com>
 2020-02-24 15:47:32 -08:00
Tonis Tiigi 8f52339933 dockerfile: add test for whitelisted devices 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2020-01-30 18:43:04 -08:00
Tonis Tiigi 572a2b5718 entitlements: mount loop devices relative to next free device 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2020-01-30 13:47:44 -08:00
Tonis Tiigi fc186a8b89 oci: mount whitelist of devices on insecure security mode 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2020-01-30 13:07:29 -08:00
Paul "TBBle" Hampson e11b881c12 Set sensible defaults for Windows installations 
Non-packaged execution will need this to be overridden anyway, and it
avoids a surprise "Drop state data into the current working directory"
event.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
 2020-01-30 00:34:44 +11:00
Tõnis Tiigi 8a267827cd
Merge pull request #1316 from coryb/goroutine-leak 
ensure context is cancelled to prevent goroutine leaks from grpc.newClientStream
 2020-01-16 17:35:11 -08:00
岁丰 3a0bfbe1ca fix legacy config media type application/octet-stream 
Signed-off-by: genglu <genglu.gl@antfin.com>
 2020-01-13 11:20:00 +08:00
Cory Bennett 463fc8d1b8 ensure context is cancelled to prevent goroutine leaks from grpc.newClientStream 
Signed-off-by: Cory Bennett <cbennett@netflix.com>
 2020-01-07 15:22:59 -08:00
Wei Fu 1845c31ee7 push: update dist repo source for mountFrom 
For new built layers, it can be pushed into remote registry. However, it
might not be pulled as base layer. Before this commit, the dist repo
source label for mountFrom call only is updated at pull stage. Without
mountFrom, it will take long time to push existing layers which can be
mountFrom. Based on this case, we should update dist repo source after
pushing layer successfully.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
 2019-12-07 00:37:19 +08:00
Akihiro Suda 5938170b84 hack: rename Dockerfiles 
Fix https://github.com/moby/buildkit/issues/1208

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 2019-10-18 17:21:48 +09:00
Tonis Tiigi 339d4b2fef leaseutil: mark temporary leases with timestamps 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-10-16 10:35:50 -07:00
Tonis Tiigi 6be136db6e cleanup unused code 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-10-16 10:33:01 -07:00
Tonis Tiigi a9209caa93 clean up temporary leases on startup after crash 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-10-16 10:32:57 -07:00
Tonis Tiigi 688e2c2272 cache: update components to new lease based cache manager 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-10-16 10:32:04 -07:00
Akihiro Suda e2ea141383 hack: remove legacy Dockerfile 
Fix #1022

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 2019-10-13 00:10:27 +09:00
Derek McGowan d5108d038d Update to containerd 1.3.0 
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
 2019-09-30 14:45:18 -07:00
Tonis Tiigi 211e20a587 vendor: update containerd to v1.3.0-rc.2 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-09-20 14:59:57 -07:00
Sam Whited e90be385b4 all: factor only required methods out of Sandbox 
Signed-off-by: Sam Whited <sam@samwhited.com>
 2019-08-27 16:54:20 -05:00
Tõnis Tiigi df7e93a159
Merge pull request #1147 from tonistiigi/cross-repo-push 
add cross-repo push support
 2019-08-27 10:48:43 -07:00
Sam Whited 93687ae5bf util/testutil/integration: s/TestConf/testConf/ 
Signed-off-by: Sam Whited <sam@samwhited.com>
 2019-08-26 07:56:33 -05:00
Tonis Tiigi 481d39c176 add cross-repo push support 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-22 17:25:13 -07:00
Tonis Tiigi fdce39046a vendor: update containerd to v1.3.0-beta.2 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-21 20:22:55 -07:00
Tonis Tiigi e86374886a util: check for localhost for plainhttp 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-20 17:03:04 -07:00
Tonis Tiigi be3635e8cb util: remove unused dockerexporter package 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-20 17:03:04 -07:00
Tonis Tiigi b407790852 update containerd daemon to 1.2.7 and old to 1.1.7 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-20 17:02:43 -07:00
Tonis Tiigi 615347271d vendor: update containerd to 1.3.0-beta.0 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-20 17:00:47 -07:00
Akihiro Suda a545b2dd5b
Merge pull request #1120 from tonistiigi/ci-caching 
Use buildkit cache and parallelization in CI
 2019-08-21 08:21:11 +09:00
Tonis Tiigi 2cea1107d6 travis: add ci caching 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-17 09:13:06 -07:00
Tonis Tiigi b8284301fd integration: detect double released and leaked mountpoints 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-16 08:03:26 -07:00
Tibor Vass 4c09c48d1d
Merge pull request #1114 from tonistiigi/cni-refactor 
network: refactor cni support to multiple packages
 2019-08-06 18:56:11 -07:00
Tonis Tiigi 57d19b1208 network: refactor cni support to multiple packages 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-06 12:52:37 -07:00
Tõnis Tiigi 940aab83bc
Merge pull request #1112 from tiborvass/detect-i386 
binfmt_misc: add detection for 386
 2019-08-06 12:27:03 -07:00
Tibor Vass d8f78dca34 binfmt_misc: add detection for 386 
Detects x86 32-bit architectures

Signed-off-by: Tibor Vass <tibor@docker.com>
 2019-08-06 01:18:55 +00:00
Tonis Tiigi 8ad218804e correct int64 alignment 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-08-05 17:20:23 -07:00
Tõnis Tiigi 2439a117e4
Merge pull request #1103 from tonistiigi/power-detect 
binfmt_misc: add support for s390x and ppc64le
 2019-07-31 10:19:28 -07:00
Tonis Tiigi a805bc9d29 flightcontrol: mitigate retry error 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-30 16:05:46 -07:00
Tonis Tiigi 43daf62710 binfmt_misc: add support for s390x and ppc64le 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-30 14:55:46 -07:00
Akihiro Suda d750cb188a
Merge pull request #1073 from tonistiigi/cni-net 
add cni networking support
 2019-07-19 10:47:27 +09:00
Tonis Tiigi 61a4e20547 util: patch atomic 64bit alignment 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-16 17:23:36 -07:00
Tonis Tiigi acbdfc2851 util: add warning if network fallback is used 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-15 10:53:18 -07:00
Tonis Tiigi 954b73dae1 network: move ns creation from reexec to linkname 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-12 14:57:10 -07:00
Tonis Tiigi e38512c056 testutil: add logs printing on error 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-12 11:00:07 -07:00
Tonis Tiigi 653c91e114 network: add non-lazy cni network init 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-12 11:00:02 -07:00
Tonis Tiigi e7759a861b client: add cni network tests 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-10 18:00:06 -07:00
Tonis Tiigi bc7a6f2556 add cni networking support 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-07-10 14:42:30 -07:00
zabio3 be2691d06c using raw string literal 
regular expressions have their own escape sequences, raw strings can improve their readability.
Signed-off-by: Tomohiro Kusumoto <zabio1192@gmail.com>
 2019-06-30 12:24:25 +09:00
Tibor Vass 914d86758c
Merge pull request #1024 from tonistiigi/gcr-workaround 
pull: add cache for gcr bug
 2019-06-17 10:36:49 -07:00
Tonis Tiigi 964d73da58 binfmt_misc: add riscv64 detection 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-06-03 23:21:25 -07:00
Tonis Tiigi 42cd080667 imageutil: keep config and manifest lease for time based cache 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-05-28 19:18:56 -07:00
Tonis Tiigi ab23a1ab1b pull: add cache for gcr bug 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-05-28 18:51:55 -07:00
Tonis Tiigi d72c19071a imageutil: use leases on fetching config 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-05-28 14:39:05 -07:00
Tonis Tiigi 8e25187cc7 pull: fix content blobs deletion on pull race 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-05-28 14:39:05 -07:00
msg 78a8e643f6 Add missing locks around broadcasts 
Signed-off-by: Mark Gordon <msg555@gmail.com>
 2019-05-10 18:27:37 -04:00
Tonis Tiigi 0dfe132df3 binfmt_misc: detect arm64 properly 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-17 16:14:08 -07:00
Tonis Tiigi c277824a71 progressui: allow vertex reset 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-09 17:43:52 -07:00
Tonis Tiigi a61d7a40a2 binfmt_misc: fix building on windows 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-03 00:23:44 -07:00
Tonis Tiigi e1d2033bf1 progressui: allow unclipped output with env 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-02 16:51:37 -07:00
Tonis Tiigi 770dbc81bf progressui: print error again on plain mode 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-02 16:45:17 -07:00
Tonis Tiigi d451b66bae progressui: improve plain progress 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-02 16:41:07 -07:00
Tonis Tiigi 9b081e607d progressui: fix padding length 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-02 08:50:25 -07:00
Tonis Tiigi 8908d4934a progressui: prioritize already shown logs 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-02 08:45:40 -07:00
Tonis Tiigi 9363cbb19a progressui: limit refresh rate and make configurable 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-02 08:19:08 -07:00
Tonis Tiigi 9e73ce6da2 progressui: add logs to the terminal output 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-01 19:48:59 -07:00
Tonis Tiigi 12f178c045 progressui: wrap out of screen incomplete rows 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-01 13:51:50 -07:00
Tonis Tiigi 823e17eccd progressui: cache jobs 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-04-01 10:57:45 -07:00
Tõnis Tiigi 758c61e873
Merge pull request #570 from kunalkushwaha/entirlement-revised 
security entitlement support
 2019-03-28 16:14:06 -07:00
Tonis Tiigi 01a8de7d74 integration: secmode switch support and security testcase 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>
 2019-03-27 13:57:03 +09:00
Kunal Kushwaha a2bbb5ff39 security entitlement support 
Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
 2019-03-27 13:57:03 +09:00
Tibor Vass fe0b8a4ec7
Merge pull request #902 from tonistiigi/itegration-update 
integration: generalize pkg
 2019-03-26 16:35:12 -07:00
Tõnis Tiigi 2453e6f388
Merge pull request #854 from chendave/hint 
Check the validity of the platforms
 2019-03-24 09:09:08 -07:00
Dave Chen aa31ff073f Check the validity of the platforms 
platforms can still be added but some warning message
will be emitted if the platform cannot pass the validity
check.

Signed-off-by: Dave Chen <dave.chen@arm.com>
 2019-03-23 21:09:42 -07:00
Tonis Tiigi 7e52b33bf8 integration: generalize pkg 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-03-21 23:49:08 -07:00
Tibor Vass 9a9e755588
Merge pull request #887 from tonistiigi/push-by-digest 
exporter: allow push by digest in image exporter
 2019-03-20 19:13:09 -07:00
Tibor Vass 9e8dfa72d3
Merge pull request #885 from tonistiigi/content-gc 
content: fix setting wrong gc labels on config query
 2019-03-20 18:52:41 -07:00
Akihiro Suda db01ff5df5
Merge pull request #891 from chendave/deprecated 
Stop using the deprecated way for build
 2019-03-20 13:46:02 +09:00
Dave Chen c7ac2f392a Stop using the deprecated way for build 
Signed-off-by: Dave Chen <dave.chen@arm.com>
 2019-03-19 19:01:31 -07:00
hpandeycodeit 271f59fe60 Added support for mutiple tags - docker build 
Signed-off-by: hpandeycodeit <hpandey@pivotal.io>
 2019-03-18 17:23:18 -07:00
Tonis Tiigi 37bfc6546c exporter: allow push by digest in image exporter 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-03-18 16:00:48 -07:00
Tonis Tiigi 2dc7a133a2 content: fix setting wrong gc labels on config query 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-03-18 12:00:09 -07:00
Tõnis Tiigi 0c747f4276
Merge pull request #861 from tonistiigi/disable-gc 
integration: disable gc
 2019-03-17 18:01:29 -07:00
Akihiro Suda cd89a8ce3d go 1.12 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
 2019-03-17 04:38:23 +09:00
zabio3 f02cc76b2a Fix typo 
Signed-off-by: Tomohiro Kusumoto <zabio1192@gmail.com>
 2019-03-16 17:39:02 +09:00
Dave Chen 156754dc78 Fix the warning for the file not end with newline 
arm-linux-gnueabihf-as -o exit.o exit.arm.s

exit.arm.s: Assembler messages:
exit.arm.s: Warning: end of file not at end of a line; newline inserted

Signed-off-by: Dave Chen <dave.chen@arm.com>
 2019-03-12 01:49:38 -07:00
Tonis Tiigi aece2ac1aa integration: disable gc 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-03-10 23:45:48 -07:00
Tonis Tiigi 632797cef0 vendor: udpate fsutil to b4281fa 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-03-05 17:34:01 -08:00
Akihiro Suda 2513fcf7d8
Merge pull request #840 from tonistiigi/qemu-detection 
util: add binfmt_misc binary detection
 2019-03-02 15:38:08 +09:00
Tonis Tiigi fb73a926c0 util: add binfmt_misc binary detection 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-02-28 11:00:04 -08:00
Derek McGowan edd603e4cd Update containerd vendor 
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
 2019-02-13 11:03:48 -08:00
Tonis Tiigi 97eff70c5e inline remote cache support 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2019-01-21 19:39:15 -08:00
Tonis Tiigi 88c81ee6d5 testutil: use different containerd debug sock 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-16 19:46:31 -07:00
Akihiro Suda 0d80bd17a3
Merge pull request #687 from tonistiigi/dockerfile-testing 
dockerfile: add testing external dockerfile features
 2018-10-16 15:58:55 +09:00
Tonis Tiigi b15990f799 hack: add better caching 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-15 22:27:13 -07:00
Tonis Tiigi 1be3e43527 testutil: add testing a random worker 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-15 22:27:13 -07:00
Tonis Tiigi 706fa2556a dockerfile: add testing external dockerfile features 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-15 22:27:07 -07:00
Akihiro Suda 048130d1d0 simplify rootless 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
 2018-10-16 14:05:58 +09:00
Tonis Tiigi 1f51f5ea11 testutil: avoid excessive daemons in integration tests 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-11 16:47:35 -07:00
Tonis Tiigi 43bd294446 integration: add setsid for sigterm 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-10 23:26:36 -07:00
Tonis Tiigi 89e8097d4c fix setting uncompressed label on content 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-08 23:11:25 -07:00
Tonis Tiigi 58a6203857 contentutil: add ref lock on push 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-05 17:21:38 -07:00
Tonis Tiigi 8360d73946 testutil: avoid overriding cleanup to nil on error 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-05 17:21:34 -07:00
Tibor Vass a0c740485c
Merge pull request #663 from tonistiigi/opentracing-fix 
solver: fix opentracing providers
 2018-10-03 11:39:29 -07:00
Tibor Vass ae84fa2c9a flightcontrol: add exponential backoff to Group.Do 
This patch fixes a stack overflow panic by calling Do in a loop
instead of relying on recursion, with an added exponential
backoff which errors out if greater than 3 seconds.

Signed-off-by: Tibor Vass <tibor@docker.com>
 2018-10-03 17:56:18 +00:00
Tonis Tiigi b26e666db9 solver: fix opentracing providers 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-10-02 23:11:17 -07:00
Tõnis Tiigi 39404586a5
Merge pull request #622 from tonistiigi/df-modes-switch 
dockerfile: enable frontend selection in integration tests
 2018-09-20 14:44:11 -07:00
Tibor Vass 9890dda814
Merge pull request #634 from tonistiigi/schema1-config-fix 
imageutil: fix getting schema1 configs
 2018-09-19 15:50:52 -07:00
Tonis Tiigi fe71cd39bd imageutil: fix getting schema1 configs 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-19 14:09:32 -07:00
Tibor Vass cb0d51cca3
Merge pull request #630 from tonistiigi/cleanup 
golint and misspell cleanup
 2018-09-19 12:01:45 -07:00
Tonis Tiigi a75983ddb9 integration: pass mirrored images from test 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-18 22:07:38 -07:00
Tonis Tiigi a0d7ed9da0 integration: add passing matrices of options 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-18 22:07:38 -07:00
Tonis Tiigi 0940cdc6fe update golint comments 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-18 22:06:47 -07:00
Tonis Tiigi 301da72ce3 misspell fixes 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-18 22:06:38 -07:00
Tonis Tiigi 087e11eedd integration: fix config permissions for rootless 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-11 21:53:40 -07:00
Tonis Tiigi fe8f2c9910 integration: fix cleanup of registry data 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-11 18:37:27 -07:00
Tonis Tiigi 75ea12b6c9 integration: use local registry mirrors 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-11 18:37:21 -07:00
Tonis Tiigi ecd4a22546 resolver: add config support for mirrors/plainhttp 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-09-07 18:44:45 -07:00
Akihiro Suda 756ca6cc6d
Merge pull request #602 from tonistiigi/gc 
automatic GC
 2018-09-05 10:47:21 +09:00
Ian Campbell 7cb70e1c31 Initialise workers' label maps before assigning. 
Otherwise:

    panic: assignment to entry in nil map

    goroutine 1 [running]:
    main.applyOCIFlags(0xc4200e71e0, 0xc420400000, 0x0, 0x0)
    	/go/src/github.com/moby/buildkit/cmd/buildkitd/main_oci_worker.go:97 +0x1ac
    main.ociWorkerInitializer(0xc4200e71e0, 0xc4204104e0, 0xc420400000, 0x43409b, 0x12, 0xc42026b0f8, 0x4337fc, 0xc420000180)
    	/go/src/github.com/moby/buildkit/cmd/buildkitd/main_oci_worker.go:118 +0x50
    main.newWorkerController(0xc4200e71e0, 0xc4204104e0, 0xc420400000, 0xc420422000, 0xe5dc54, 0x11)
    	/go/src/github.com/moby/buildkit/cmd/buildkitd/main.go:520 +0x324
    main.newController(0xc4200e71e0, 0xc420400000, 0x1c0, 0x0, 0x0)
    	/go/src/github.com/moby/buildkit/cmd/buildkitd/main.go:489 +0xdc
    main.main.func3(0xc4200e71e0, 0x0, 0x0)
    	/go/src/github.com/moby/buildkit/cmd/buildkitd/main.go:203 +0x3dd
    github.com/moby/buildkit/vendor/github.com/urfave/cli.HandleAction(0xcdd420, 0xe93e98, 0xc4200e71e0, 0xc4200e71e0, 0xc42026b888)
    	/go/src/github.com/moby/buildkit/vendor/github.com/urfave/cli/app.go:502 +0xc8
    github.com/moby/buildkit/vendor/github.com/urfave/cli.(*App).Run(0xc4201b6540, 0xc4200300a0, 0xa, 0xa, 0x0, 0x0)
    	/go/src/github.com/moby/buildkit/vendor/github.com/urfave/cli/app.go:268 +0x60c
    main.main()
    	/go/src/github.com/moby/buildkit/cmd/buildkitd/main.go:238 +0xc64

Also add some random labels to the integration sandbox (which I have confirmed
is enough to trigger this issue before the fix).

Signed-off-by: Ian Campbell <ijc@docker.com>
 2018-09-03 11:35:36 +01:00
Tonis Tiigi 8fea3f25e1 util: add a nonblocking throttle variant 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-08-31 16:36:58 -07:00
Tonis Tiigi c524709f4a buildkitd: add config file support 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-08-30 16:11:55 -07:00
Derek McGowan 279a144686 Update containerd vendor 
Picks up platform changes

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
 2018-08-28 14:26:14 -07:00
Akihiro Suda 557bba11c9 containerd: disable CRI plugin 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
 2018-08-23 18:14:57 +09:00
Akihiro Suda b90615d34d integration: print containerd logs on failure 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
 2018-08-23 18:14:57 +09:00
Tibor Vass 2f0c048493 network: move handling of NetMode_UNSET to Default() 
This allows other workers to implement their own behavior for NetMode_UNSET

Signed-off-by: Tibor Vass <tibor@docker.com>
 2018-08-23 00:06:06 +00:00
Michael Crosby b97bc71adb Refactor networking with ns paths 
This fixes the issues where buildkit and callers do not have to be a
subpreaper in order to use networking.  I can add CNI provider later,
with a hidden sub command to create a new network namespace and bind
mount it to buildkit's state dir.

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
 2018-08-21 13:37:47 -04:00
Tonis Tiigi 130f5f5ab0 solver: net host with basic entitlements support 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-08-09 14:03:35 -07:00
Tõnis Tiigi 785436a312
Merge pull request #563 from ijc/progressui-custom-operation 
progressui: allow caller to customise "Building" string
 2018-08-09 10:49:29 -07:00
Ian Campbell ccc559bc43 progressui: allow caller to customise "Building" string 
In clients which are doinging multiple builds or phases it can be useful to say
something more specific here (e.g. "Building first image", "Probing" etc)

Signed-off-by: Ian Campbell <ijc@docker.com>
 2018-08-08 16:29:01 +01:00
Kunal Kushwaha 765f1b64b9 executor: allow network providers 
Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-08-07 11:51:56 -07:00
Tonis Tiigi e971b7cddf pull: handle resolvemode 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-07-25 18:20:55 -07:00
Tonis Tiigi f719aadcba dockerfile: add tests for multi-platform exports 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-07-25 16:01:12 -07:00
Tonis Tiigi 6be1257f5d export: manifest list support 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-07-25 16:01:12 -07:00
Tõnis Tiigi 5098434f33
Merge pull request #530 from tonistiigi/winlayers-panic 
winlayers: discard reader on apply errors
 2018-07-25 12:59:35 -07:00
Ian Campbell e0196c9a12 apicaps: record the correct caps when constructing a CapSet 
We need to capture `c` within the loop, otherwise all of the entries of `m` end
up pointing to the same thing, which is the last cap in `range caps`.

The symptom was that all caps were enabled/disabled based on the last cap's
setting and not their own.

Add a test for this.

Signed-off-by: Ian Campbell <ijc@docker.com>
 2018-07-25 14:29:16 +01:00
Tonis Tiigi 384263c68d winlayers: discard reader on apply errors 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-07-20 18:37:26 -07:00
Akihiro Suda a9dcf63f45 integration: skip rootless if unsupported 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
 2018-07-20 19:18:51 +09:00
Tonis Tiigi bc765861be diff: implement windows layer support for linux 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-07-16 16:33:21 -07:00
Tõnis Tiigi aee2723382
Merge pull request #480 from ijc/less-chatty-non-console-progress 
Reduce verbosity of non-console solve status.
 2018-07-10 08:25:12 -07:00
Ian Campbell dbd3d86a35 Reduce verbosity of non-console solve status. 
Only report progress at most every 5s or 5% completion, which ever comes first.

Signed-off-by: Ian Campbell <ijc@docker.com>
 2018-07-10 16:06:31 +01:00
Tonis Tiigi 90d164ced5 gateway: inital caps detection support 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-07-09 16:32:38 -07:00
Tonis Tiigi db5b0f1b9a api: add caps support for versioning 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
 2018-07-09 16:32:34 -07:00
Tõnis Tiigi 77e4fcd0ec
Merge pull request #491 from frezbo/feature/fix-datatype-mismatch 
Fixing mismatch
 2018-07-06 11:53:14 -07:00
Noel Georgi 8753e76a4d
Fixing mismatch 
Signed-off-by: Noel Georgi <18496730+frezbo@users.noreply.github.com>
 2018-07-06 17:48:17 +05:30