e56e7ba46b
flightcontrol: fix possible invalid cancellation
...
There was a race with context getting cancelled and new request
arriving that could resulted new request to receive cancelled result
as well. This happened because lock was held when getting the Done()
channel but it could have been already released by the time returned
channel was closed.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-12-11 00:57:12 -08:00
37b8832d00
upgrade errors checks to Is()
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2020-04-18 22:53:38 -07:00
463fc8d1b8
ensure context is cancelled to prevent goroutine leaks from grpc.newClientStream
...
Signed-off-by: Cory Bennett <cbennett@netflix.com>
2020-01-07 15:22:59 -08:00
a805bc9d29
flightcontrol: mitigate retry error
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2019-07-30 16:05:46 -07:00
f02cc76b2a
Fix typo
...
Signed-off-by: Tomohiro Kusumoto <zabio1192@gmail.com>
2019-03-16 17:39:02 +09:00
ae84fa2c9a
flightcontrol: add exponential backoff to Group.Do
...
This patch fixes a stack overflow panic by calling Do in a loop
instead of relying on recursion, with an added exponential
backoff which errors out if greater than 3 seconds.
Signed-off-by: Tibor Vass <tibor@docker.com>
2018-10-03 17:56:18 +00:00
0940cdc6fe
update golint comments
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-09-18 22:06:47 -07:00
6e40e83d35
Remove net/context dependencies
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2018-01-17 09:11:22 -08:00
e4f6a5e752
set more tests to parallel
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-12-08 18:19:08 -08:00
01aaf130e5
solver: refactor to a shared vertex solver model
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-09-18 13:58:33 -07:00
5cbe154368
flightcontrol: better errRetry handling
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-07-25 15:54:21 -07:00
65c2f8ef4c
solver: cache vertex progress for replays
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-06-29 22:42:00 -07:00
3b388fbefc
progress: fix closing progress writers on cancel
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-06-29 20:41:53 -07:00
ec5c60283e
solver: add vertex sharing on concurrent builds
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-06-28 21:52:05 -07:00
b573060eea
project: remove poc label
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-06-23 09:37:36 -07:00
0a7a2c1da3
solver: update exec ops to separate functions
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-06-19 14:32:50 -07:00
4ed7fa3280
progress: refactor progress IDs to items
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-06-19 14:32:50 -07:00
e88c9468dd
util: add flightcontrol sync primitive
...
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-05-30 15:00:40 -07:00
Tonis Tiigi
Cory Bennett
zabio3
Tibor Vass