2017-12-15 07:00:13 +00:00
|
|
|
// +build linux,!no_oci_worker
|
2017-06-08 00:54:29 +00:00
|
|
|
|
|
|
|
package main
|
|
|
|
|
|
|
|
import (
|
2017-11-21 08:08:36 +00:00
|
|
|
"os/exec"
|
2018-08-29 21:00:25 +00:00
|
|
|
"strconv"
|
2017-11-21 08:08:36 +00:00
|
|
|
|
2018-04-03 09:37:16 +00:00
|
|
|
ctdsnapshot "github.com/containerd/containerd/snapshots"
|
|
|
|
"github.com/containerd/containerd/snapshots/native"
|
2018-02-26 08:17:33 +00:00
|
|
|
"github.com/containerd/containerd/snapshots/overlay"
|
2018-08-29 21:00:25 +00:00
|
|
|
"github.com/moby/buildkit/cmd/buildkitd/config"
|
2017-11-21 08:08:36 +00:00
|
|
|
"github.com/moby/buildkit/worker"
|
2017-12-15 08:06:54 +00:00
|
|
|
"github.com/moby/buildkit/worker/base"
|
2017-11-21 08:08:36 +00:00
|
|
|
"github.com/moby/buildkit/worker/runc"
|
2018-07-02 04:56:50 +00:00
|
|
|
"github.com/opencontainers/runc/libcontainer/system"
|
2018-02-26 08:17:33 +00:00
|
|
|
"github.com/pkg/errors"
|
2017-11-21 08:08:36 +00:00
|
|
|
"github.com/sirupsen/logrus"
|
2017-06-08 00:54:29 +00:00
|
|
|
"github.com/urfave/cli"
|
|
|
|
)
|
|
|
|
|
2017-11-21 08:08:36 +00:00
|
|
|
func init() {
|
2018-08-29 21:00:25 +00:00
|
|
|
defaultConf, _ := defaultConf()
|
|
|
|
|
|
|
|
enabledValue := func(b *bool) string {
|
|
|
|
if b == nil {
|
|
|
|
return "auto"
|
|
|
|
}
|
|
|
|
return strconv.FormatBool(*b)
|
|
|
|
}
|
|
|
|
|
|
|
|
if defaultConf.Workers.OCI.Snapshotter == "" {
|
|
|
|
defaultConf.Workers.OCI.Snapshotter = "auto"
|
|
|
|
}
|
|
|
|
|
2018-05-30 02:49:43 +00:00
|
|
|
flags := []cli.Flag{
|
2017-11-21 08:08:36 +00:00
|
|
|
cli.StringFlag{
|
|
|
|
Name: "oci-worker",
|
|
|
|
Usage: "enable oci workers (true/false/auto)",
|
2018-08-29 21:00:25 +00:00
|
|
|
Value: enabledValue(defaultConf.Workers.OCI.Enabled),
|
2017-12-19 09:34:34 +00:00
|
|
|
},
|
|
|
|
cli.StringSliceFlag{
|
|
|
|
Name: "oci-worker-labels",
|
|
|
|
Usage: "user-specific annotation labels (com.example.foo=bar)",
|
|
|
|
},
|
2018-02-19 05:33:49 +00:00
|
|
|
cli.StringFlag{
|
|
|
|
Name: "oci-worker-snapshotter",
|
2018-04-03 09:37:16 +00:00
|
|
|
Usage: "name of snapshotter (overlayfs or native)",
|
2018-08-29 21:00:25 +00:00
|
|
|
Value: defaultConf.Workers.OCI.Snapshotter,
|
2018-05-30 02:49:43 +00:00
|
|
|
},
|
2018-06-22 02:06:12 +00:00
|
|
|
cli.StringSliceFlag{
|
|
|
|
Name: "oci-worker-platform",
|
|
|
|
Usage: "override supported platforms for worker",
|
|
|
|
},
|
2018-05-30 02:49:43 +00:00
|
|
|
}
|
|
|
|
n := "oci-worker-rootless"
|
|
|
|
u := "enable rootless mode"
|
2018-07-02 04:56:50 +00:00
|
|
|
if system.RunningInUserNS() {
|
2018-05-30 02:49:43 +00:00
|
|
|
flags = append(flags, cli.BoolTFlag{
|
|
|
|
Name: n,
|
|
|
|
Usage: u,
|
|
|
|
})
|
|
|
|
} else {
|
|
|
|
flags = append(flags, cli.BoolFlag{
|
|
|
|
Name: n,
|
|
|
|
Usage: u,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
registerWorkerInitializer(
|
|
|
|
workerInitializer{
|
|
|
|
fn: ociWorkerInitializer,
|
|
|
|
priority: 0,
|
2018-02-19 05:33:49 +00:00
|
|
|
},
|
2018-05-30 02:49:43 +00:00
|
|
|
flags...,
|
2017-12-19 09:34:34 +00:00
|
|
|
)
|
2018-05-30 02:49:43 +00:00
|
|
|
// TODO: allow multiple oci runtimes
|
2017-11-21 08:08:36 +00:00
|
|
|
}
|
|
|
|
|
2018-08-29 21:00:25 +00:00
|
|
|
func applyOCIFlags(c *cli.Context, cfg *config.Config) error {
|
|
|
|
if cfg.Workers.OCI.Snapshotter == "" {
|
|
|
|
cfg.Workers.OCI.Snapshotter = "auto"
|
2017-11-21 08:08:36 +00:00
|
|
|
}
|
2018-08-29 21:00:25 +00:00
|
|
|
|
|
|
|
if c.GlobalIsSet("oci-worker") {
|
|
|
|
boolOrAuto, err := parseBoolOrAuto(c.GlobalString("oci-worker"))
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
cfg.Workers.OCI.Enabled = boolOrAuto
|
2017-11-21 08:08:36 +00:00
|
|
|
}
|
2018-08-29 21:00:25 +00:00
|
|
|
|
2017-12-19 09:34:34 +00:00
|
|
|
labels, err := attrMap(c.GlobalStringSlice("oci-worker-labels"))
|
|
|
|
if err != nil {
|
2018-08-29 21:00:25 +00:00
|
|
|
return err
|
|
|
|
}
|
Initialise workers' label maps before assigning.
Otherwise:
panic: assignment to entry in nil map
goroutine 1 [running]:
main.applyOCIFlags(0xc4200e71e0, 0xc420400000, 0x0, 0x0)
/go/src/github.com/moby/buildkit/cmd/buildkitd/main_oci_worker.go:97 +0x1ac
main.ociWorkerInitializer(0xc4200e71e0, 0xc4204104e0, 0xc420400000, 0x43409b, 0x12, 0xc42026b0f8, 0x4337fc, 0xc420000180)
/go/src/github.com/moby/buildkit/cmd/buildkitd/main_oci_worker.go:118 +0x50
main.newWorkerController(0xc4200e71e0, 0xc4204104e0, 0xc420400000, 0xc420422000, 0xe5dc54, 0x11)
/go/src/github.com/moby/buildkit/cmd/buildkitd/main.go:520 +0x324
main.newController(0xc4200e71e0, 0xc420400000, 0x1c0, 0x0, 0x0)
/go/src/github.com/moby/buildkit/cmd/buildkitd/main.go:489 +0xdc
main.main.func3(0xc4200e71e0, 0x0, 0x0)
/go/src/github.com/moby/buildkit/cmd/buildkitd/main.go:203 +0x3dd
github.com/moby/buildkit/vendor/github.com/urfave/cli.HandleAction(0xcdd420, 0xe93e98, 0xc4200e71e0, 0xc4200e71e0, 0xc42026b888)
/go/src/github.com/moby/buildkit/vendor/github.com/urfave/cli/app.go:502 +0xc8
github.com/moby/buildkit/vendor/github.com/urfave/cli.(*App).Run(0xc4201b6540, 0xc4200300a0, 0xa, 0xa, 0x0, 0x0)
/go/src/github.com/moby/buildkit/vendor/github.com/urfave/cli/app.go:268 +0x60c
main.main()
/go/src/github.com/moby/buildkit/cmd/buildkitd/main.go:238 +0xc64
Also add some random labels to the integration sandbox (which I have confirmed
is enough to trigger this issue before the fix).
Signed-off-by: Ian Campbell <ijc@docker.com>
2018-09-03 10:31:03 +00:00
|
|
|
if cfg.Workers.OCI.Labels == nil {
|
|
|
|
cfg.Workers.OCI.Labels = make(map[string]string)
|
|
|
|
}
|
2018-08-29 21:00:25 +00:00
|
|
|
for k, v := range labels {
|
|
|
|
cfg.Workers.OCI.Labels[k] = v
|
|
|
|
}
|
|
|
|
if c.GlobalIsSet("oci-worker-snapshotter") {
|
|
|
|
cfg.Workers.OCI.Snapshotter = c.GlobalString("oci-worker-snapshotter")
|
|
|
|
}
|
|
|
|
|
|
|
|
if c.GlobalIsSet("rootless") || c.GlobalBool("rootless") {
|
|
|
|
cfg.Workers.OCI.Rootless = c.GlobalBool("rootless")
|
|
|
|
}
|
|
|
|
if c.GlobalIsSet("oci-worker-rootless") {
|
|
|
|
cfg.Workers.OCI.Rootless = c.GlobalBool("oci-worker-rootless")
|
|
|
|
}
|
|
|
|
|
|
|
|
if platforms := c.GlobalStringSlice("oci-worker-platform"); len(platforms) != 0 {
|
|
|
|
cfg.Workers.OCI.Platforms = platforms
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func ociWorkerInitializer(c *cli.Context, common workerInitializerOpt) ([]worker.Worker, error) {
|
|
|
|
if err := applyOCIFlags(c, common.config); err != nil {
|
2017-12-19 09:34:34 +00:00
|
|
|
return nil, err
|
|
|
|
}
|
2018-08-29 21:00:25 +00:00
|
|
|
|
|
|
|
cfg := common.config.Workers.OCI
|
|
|
|
|
|
|
|
if (cfg.Enabled == nil && !validOCIBinary()) || (cfg.Enabled != nil && !*cfg.Enabled) {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
snFactory, err := snapshotterFactory(common.config.Root, cfg.Snapshotter)
|
2018-02-26 08:17:33 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
2018-08-29 21:00:25 +00:00
|
|
|
|
|
|
|
if cfg.Rootless {
|
2018-05-30 02:49:43 +00:00
|
|
|
logrus.Debugf("running in rootless mode")
|
|
|
|
}
|
2018-08-29 21:00:25 +00:00
|
|
|
opt, err := runc.NewWorkerOpt(common.config.Root, snFactory, cfg.Rootless, cfg.Labels)
|
2017-11-21 08:08:36 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
opt.SessionManager = common.sessionManager
|
2018-08-30 21:06:27 +00:00
|
|
|
opt.GCPolicy = getGCPolicy(cfg.GCPolicy, common.config.Root)
|
2018-09-07 20:45:59 +00:00
|
|
|
opt.ResolveOptionsFunc = resolverFunc(common.config)
|
2018-08-29 21:00:25 +00:00
|
|
|
|
|
|
|
if platformsStr := cfg.Platforms; len(platformsStr) != 0 {
|
2018-06-22 02:06:12 +00:00
|
|
|
platforms, err := parsePlatforms(platformsStr)
|
|
|
|
if err != nil {
|
|
|
|
return nil, errors.Wrap(err, "invalid platforms")
|
|
|
|
}
|
|
|
|
opt.Platforms = platforms
|
|
|
|
}
|
2017-12-15 08:06:54 +00:00
|
|
|
w, err := base.NewWorker(opt)
|
2017-11-21 08:08:36 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
2017-12-15 08:06:54 +00:00
|
|
|
return []worker.Worker{w}, nil
|
2017-06-08 19:00:31 +00:00
|
|
|
}
|
|
|
|
|
2018-06-05 08:38:16 +00:00
|
|
|
func snapshotterFactory(commonRoot, name string) (runc.SnapshotterFactory, error) {
|
|
|
|
if name == "auto" {
|
|
|
|
if err := overlay.Supported(commonRoot); err == nil {
|
|
|
|
logrus.Debug("auto snapshotter: using overlayfs")
|
|
|
|
name = "overlayfs"
|
|
|
|
} else {
|
|
|
|
logrus.Debugf("auto snapshotter: using native, because overlayfs is not available for %s: %v", commonRoot, err)
|
|
|
|
name = "native"
|
|
|
|
}
|
|
|
|
}
|
2018-02-26 08:17:33 +00:00
|
|
|
snFactory := runc.SnapshotterFactory{
|
|
|
|
Name: name,
|
|
|
|
}
|
|
|
|
switch name {
|
2018-04-03 09:37:16 +00:00
|
|
|
case "native":
|
|
|
|
snFactory.New = native.NewSnapshotter
|
2018-02-26 08:17:33 +00:00
|
|
|
case "overlayfs": // not "overlay", for consistency with containerd snapshotter plugin ID.
|
2018-04-03 09:37:16 +00:00
|
|
|
snFactory.New = func(root string) (ctdsnapshot.Snapshotter, error) {
|
|
|
|
return overlay.NewSnapshotter(root)
|
|
|
|
}
|
2018-02-26 08:17:33 +00:00
|
|
|
default:
|
2018-06-05 08:38:16 +00:00
|
|
|
return snFactory, errors.Errorf("unknown snapshotter name: %q", name)
|
2018-02-26 08:17:33 +00:00
|
|
|
}
|
2018-06-05 08:38:16 +00:00
|
|
|
return snFactory, nil
|
2018-02-26 08:17:33 +00:00
|
|
|
}
|
|
|
|
|
2017-11-21 08:08:36 +00:00
|
|
|
func validOCIBinary() bool {
|
|
|
|
_, err := exec.LookPath("runc")
|
|
|
|
if err != nil {
|
|
|
|
logrus.Warnf("skipping oci worker, as runc does not exist")
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
return true
|
2017-06-08 00:54:29 +00:00
|
|
|
}
|