EbookFoundation
/
regluit
mirror of https://github.com/EbookFoundation/regluit.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #63 from Gluejar/goodreads_bug 

replaced remaining text.strip() with safe_strip(text) -- and changed saf...
pull/1/head
thatandromeda 2012-10-16 11:11:25 -07:00
parent b7f5b78720 0df16957db
commit 8bc66ad0fb
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
core/goodreads.py
View File

@ -42,9 +42,9 @@ def filter_none(d):
return d2
def safe_strip(a_string):
if a_string:
try:
return a_string.strip()
else:
except:
return ''
class GoodreadsClient(object):
@ -220,15 +220,15 @@ class GoodreadsClient(object):
reviews = doc.findall('reviews/review')
for review in reviews:
yield ({'id':review.find('id').text,
'book': {'id': review.find('book/id').text.strip(),
'book': {'id': safe_strip(review.find('book/id').text),
'isbn10':review.find('book/isbn').text,
'isbn13':review.find('book/isbn13').text,
'title':review.find('book/title').text.strip(),
'text_reviews_count':review.find('book/text_reviews_count').text.strip(),
'link':review.find('book/link').text.strip(),
'small_image_url':review.find('book/small_image_url').text.strip(),
'ratings_count':review.find('book/ratings_count').text.strip(),
'description':review.find('book/description').text.strip()}
'title':safe_strip(review.find('book/title').text),
'text_reviews_count':safe_strip(review.find('book/text_reviews_count').text),
'link':safe_strip(review.find('book/link').text),
'small_image_url':safe_strip(review.find('book/small_image_url').text),
'ratings_count':safe_strip(review.find('book/ratings_count').text),
'description':safe_strip(review.find('book/description').text)}
})
if len(reviews) == 0:
more_pages = False