EbookFoundation
/
regluit
mirror of https://github.com/EbookFoundation/regluit.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ElementTree.fromstring expects a string of utf8, not a unicode object, which works most of the time, but not if the UnicodeString contains some non-ascii data I guess. The test suite started failing with a UnicodeEncodeError: 'ascii' codec can't encode character u'\u2014' in position 12164: ordinal not in range(128), I think when the GR bookshelf used by this test changed to include some Unicode

pull/1/head
Ed Summers 2011-12-20 10:31:15 -05:00
parent 5a5ca2262e
commit 2d6a6de487
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/goodreads.py
View File

@ -119,7 +119,7 @@ class GoodreadsClient(object):
if int(response['status']) != httplib.OK:
raise GoodreadsException('Error authenticating Goodreads user: %s ' % response)
else:
doc = ET.fromstring(content)
doc = ET.fromstring(content.encode('utf-8'))
user = doc.find('user')
userid = user.get('id')
name = user.find('name').text
@ -155,10 +155,11 @@ class GoodreadsClient(object):
while (more_pages):
r = request(method,request_url,params=params)
print request_url, params
if r.status_code != httplib.OK:
raise GoodreadsException('Error in review_list_unauth: %s ' % r.content)
else:
doc = ET.fromstring(r.content)
doc = ET.fromstring(r.content.encode('utf-8'))
# for the moment convert to a iterable of book data presented as dict -- one the way to paging through all results
reviews = doc.findall('reviews/review')
for review in reviews:
@ -203,7 +204,7 @@ class GoodreadsClient(object):
if int(response['status']) != httplib.OK:
raise GoodreadsException('Error in review_list: %s ' % response)
else:
doc = ET.fromstring(content)
doc = ET.fromstring(content.encode('utf-8'))
# for the moment convert to a iterable of book data presented as dict -- one the way to paging through all results
reviews = doc.findall('reviews/review')
for review in reviews:
@ -239,7 +240,7 @@ class GoodreadsClient(object):
raise GoodreadsException('Error in shelves_list: %s %s ' % (r.headers, r.content))
else:
logger.info('headers, content: %s | %s ' % (r.headers,r.content))
doc = ET.fromstring(r.content)
doc = ET.fromstring(r.content.encode('utf-8'))
shelves = doc.find('shelves')
# do a simple parsing to a dictionary