EbookFoundation
/
regluit
mirror of https://github.com/EbookFoundation/regluit.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[#29500707] Logging an error when an attempt to cancel a transaction does not succeed

pull/1/head
Raymond Yee 2012-06-15 16:59:51 -04:00
parent 30bf30177c
commit 25268b34bc
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
payment/manager.py
View File

@ -650,11 +650,7 @@ class PaymentManager( object ):
# sadly this point is not yet late enough in the process -- needs to be moved # sadly this point is not yet late enough in the process -- needs to be moved
# until after we are certain. # until after we are certain.
if modification: if not modification:
# the pledge_modify notice is sent after the previous transaction is successfully canceled
# pledge_modified.send(sender=self, transaction=t, up_or_down="increased")
pass
else:
# BUGBUG: # BUGBUG:
# send the notice here for now # send the notice here for now
# this is actually premature since we're only about to send the user off to the payment system to # this is actually premature since we're only about to send the user off to the payment system to
@ -708,8 +704,7 @@ class PaymentManager( object ):
pledge_modified.send(sender=self, transaction=transaction, up_or_down=up_or_down) pledge_modified.send(sender=self, transaction=transaction, up_or_down=up_or_down)
else: else:
# BUGBUG: we should handle this error in which a cancellation did not happen properly logger.error("Failed to cancel transaction {0} for related transaction {1} ".format(t, transaction))
pass
return canceled return canceled