Commit Graph

24 Commits (28b6a2d53588eaaa905b45d8cbf49eb6eedd338b)

Author SHA1 Message Date
Manuel Kaufmann 632e18c121 pre-commit all the files again 2019-01-09 13:19:00 +01:00
Manuel Kaufmann 3219f7acbd Run pre-commit on all the files
$ pre-commit run --files `find readthedocs -name '*'`
2019-01-08 21:51:36 +01:00
Manuel Kaufmann c78187b62f isort all the files
$ pre-commit run python-import-sorter --files `find readthedocs -name '*.py'`

It was ran with this configuration: https://github.com/rtfd/common/pull/28
2019-01-08 20:56:20 +01:00
Manuel Kaufmann f7dea72b86 pyupgrade 1.11.0 on all code
pyupgrade --py3-plus --py3-only (*.py)
2019-01-03 16:56:33 +01:00
Rahul Tiwari 78f738b3e9 Remove unused models and forms 2018-10-25 00:57:23 +05:30
Santos Gallegos 7fb4b18bc9 Dropdown to select Advanced Settings (#4710)
* added auto suggest in version

* auto fill for branches

* changes in syntax

* switched to choicefield and multiple files in option

* futher syntax changes

*  Updates based on feedback

* Put back removed code

* Simplified logic

* Linter 👍

* Validate revert case

* Tests for AdvancedForm

* Filter by privacy level

* Remove privacy checks

* Tests for VersionForm

* Rename variables

* Fix translation

* Fix format
2018-10-23 10:50:25 -06:00
Manuel Kaufmann 745dc7483c Fix some linting 2018-01-25 20:43:54 -05:00
Anthony accc01535c Finish linting on py3ish code (#2949)
* Resolve first round of linting errors in restapi.

This is a first step and only adds docstrings, etc. It doesn't refactor any
code.

Conflicts:
	prospector-more.yml
	readthedocs/restapi/views/model_views.py

* Reduce unused params.

In several cases, we can use the provided `request` rather than access `self`
(which could make these functions easier to test in isolation). In others, the
unused args could be folded into an unnamed kwarg param.

* Don't replace section variable.

This worked as intended, but only because the overridden section variable
would later evaluate to True. Using a different variable name makes this a bit
less error-prone.

* Minor docstring update

* Fix indent on docstring

* Punt on refactoring

* Fix call args

* Try unpinning testing reqs

* Bump up prospector higher level strictness

* Linting issues: arguments-differ, len-as-condition, redefined variables

* Remove unnecessary elses

This addresses no-else-return, which removes a `return` in an `else` after an
`if` that already has a `return`. This makes the default return more obvious in
most cases.

* Fix new linting issues with import order

Also, update travis and tox config for multiple versions of python

* Another fix on travis envs
2017-06-14 09:38:03 -07:00
Hank Gay 64116bc541 Make a pass with futurize on stage 2.
Depend on futurize.
2017-05-30 18:10:44 -04:00
Hank Gay f201d150dd Make a pass w/ python-modernize. 2017-05-30 17:55:56 -04:00
smcoll 73b8e76eeb linting for builds app (#2875) 2017-05-22 15:51:14 -07:00
Eric Holscher b220f81dc6 Fix issue where VersionForm wasn't returning object on save 2015-12-11 15:38:57 -08:00
Eric Holscher b286263ed3 Automated import refactoring 2015-07-28 16:50:58 -07:00
Gregor Müllegger fb2c46a060 Adding required fields attribute to AliasForm.Meta. 2015-07-09 18:20:29 +02:00
Eric Holscher 1fdc475d3c Fix version saving 2015-01-12 16:27:19 -08:00
Eric Holscher c5170b4525 Trigger build on new version save form 2015-01-12 16:09:45 -08:00
Eric Holscher 64c3c32477 Add Versions to the top bar and make the templates nicer 2015-01-12 13:48:40 -08:00
Wraithan (Chris McDonald) d256625d83 flake8 all of the things 2013-04-07 19:55:31 -07:00
Eric Holscher 6fe57e1ef9 Revert "Revert "Add new fancy detail pages.""
This reverts commit ada53b0597.
2012-12-17 22:38:49 -08:00
Eric Holscher ada53b0597 Revert "Add new fancy detail pages."
This reverts commit acf27880f6.
2012-12-17 22:18:06 -08:00
Eric Holscher acf27880f6 Add new fancy detail pages. 2012-12-17 22:08:46 -08:00
Eric Holscher 979447aee0 Lots of little pyflakes cleanup. 2011-06-18 16:53:14 -07:00
Eric Holscher 3e1044c810 I hate forms. 2011-03-02 22:11:17 -08:00
Eric Holscher 25dd349389 added basic (read: janky) alias editing front end. 2011-03-02 21:59:32 -08:00