* Resolve first round of linting errors in restapi.
This is a first step and only adds docstrings, etc. It doesn't refactor any
code.
Conflicts:
prospector-more.yml
readthedocs/restapi/views/model_views.py
* Reduce unused params.
In several cases, we can use the provided `request` rather than access `self`
(which could make these functions easier to test in isolation). In others, the
unused args could be folded into an unnamed kwarg param.
* Don't replace section variable.
This worked as intended, but only because the overridden section variable
would later evaluate to True. Using a different variable name makes this a bit
less error-prone.
* Minor docstring update
* Fix indent on docstring
* Punt on refactoring
* Fix call args
* Try unpinning testing reqs
* Bump up prospector higher level strictness
* Linting issues: arguments-differ, len-as-condition, redefined variables
* Remove unnecessary elses
This addresses no-else-return, which removes a `return` in an `else` after an
`if` that already has a `return`. This makes the default return more obvious in
most cases.
* Fix new linting issues with import order
Also, update travis and tox config for multiple versions of python
* Another fix on travis envs
Not really sure we need to specify appdirs version here, but I'm hitting errors
installing on a virtualenv that has appdirs==1.4.0. You might need to remove the
old appdirs version before this will install at all in fact.
* Pass build env python limits to config object
* Pass in build env python limitations to config
* Exposes parsing error to user on build output
* Typo on config method
* Alter build image names
* Bump release of readthedocs-build
* Don't test BuildConfig, test our implementation
Tunes up tests, fixes a bug with logic on python version detection
* Fix tests that were depending on config wrapper tests
* WIP for integrating persistent messaging for users
Combines notifications so that email/on site messaging will all be maintained in
the same place, and can extend from each other using normal template semantics.
* Add email support, clean up implementation
* Add reqs
* Drop unnecessary string conversion
* Change admin email form to look at templates, not ask for template source
* Add docs, tests, views for processing redirects
* Do the thing I meant to do
* Drop views, just use javascript instead
This adds javascript that intercepts link clicks in notifications,
hits the dismiss url defined on the dom object, and then redirects
to the correct url of the original link.
* Move classes around and rename module
* Drop unused notification for testing
* Clean up usage, drop test uses of the views/notifications
* Add example usage that will be used for notification on resource usage
* Fix mock module path
* Add more docs around implementation
David Fischer
Eric Holscher
Anthony
Hank Gay
Alex Chan
Frederick
fmoor
smcoll
Aaron Carlisle
Nick B
Berker Peksag
Ryan P Kilby
Benjamin Bach
Sergey B Kirpichev
Kevin Deldycke