01986a634b
Rafactor test_comments to use explicit dynamic fixtures instead of canopy
2015-08-03 15:44:48 +02:00
8a441005f4
Don't use canopy in test_project
...
We want to get rid of canopy as it is not using any meaningful names. We want
the test fixtures to be created explicitly somewhere near the actual tests.
2015-08-03 15:43:40 +02:00
1f2c785992
Merge pull request #1522 from rtfd/lint-cleanup
...
Resolving lint warnings and errors
2015-07-31 11:34:02 -07:00
31ec467d13
Remove bad code about removing pdf/epub artifacts.
...
It was a missed attempt at the issue that I reverted but seem to have missed
some lines. We clear the artifacts with the
project.tasks.clear_pdf/epub_artifacts fucntions now. Syncer.remove is no
valid method.
2015-07-31 18:11:01 +02:00
f7a05381cf
Merge pull request #1507 from rtfd/cleanup-doc-embed-js
...
Cleanup doc embed js
2015-07-31 09:00:51 -07:00
964c7e0b9f
Merge pull request #1502 from rtfd/delete-pdf-epub-artifacts
...
Delete pdf/epub artifacts when their build is disabled
2015-07-31 08:57:33 -07:00
ab2034223c
Resolve linting messages in readthedocs.vcs_support.*
2015-07-31 17:51:11 +02:00
cab9805077
Resolve linting messages in readthedocs.settings.*
2015-07-31 17:51:11 +02:00
85c69ced90
Resolve linting messages in readthedocs.search.*
2015-07-31 17:51:11 +02:00
94ff257ca7
Resolve linting messages in readthedocs.rtd_tests.*
2015-07-31 17:51:11 +02:00
dc6a2fe283
Resolve linting messages in readthedocs.restapi.*
2015-07-31 17:51:11 +02:00
937f287226
Resolve linting messages in readthedocs.oauth.*
2015-07-31 17:51:11 +02:00
f85f54ea49
Resolve linting messages in readthedocs.projects.*
2015-07-31 17:51:03 +02:00
89772eb614
Merge remote-tracking branch 'origin/validate-subproject-admin'
...
Conflicts:
readthedocs/rtd_tests/tests/test_views.py
2015-07-31 08:43:51 -07:00
afcf98ba92
Resolve linting messages in readthedocs.profiles.*
2015-07-31 17:30:51 +02:00
3b80741939
Resolve linting messages in readthedocs.privacy.*
2015-07-31 17:30:51 +02:00
063ecd4bca
Resolve linting messages in readthedocs.gold.*
2015-07-31 17:30:51 +02:00
e7e21188da
Resolve linting messages in readthedocs.donate.*
2015-07-31 17:30:34 +02:00
6c65964ba5
Resolve linting messages in readthedocs.doc_builder.*
2015-07-31 17:30:34 +02:00
593b812540
Resolve linting messages in readthedocs.core.*
2015-07-31 17:30:12 +02:00
e17973e5d9
Resolve linting messages in readthedocs.comments.*
2015-07-31 17:30:12 +02:00
cca1888c9f
Resolve linting messages in readthedocs.bookmarks.*
2015-07-31 17:30:11 +02:00
28a0dfa8e8
Resolve linting messages in readthedocs.api.*
2015-07-31 17:30:11 +02:00
deb95fcaca
Merge pull request #1519 from rtfd/use-form.add_error
...
Use Django's builtin Form.add_error instead of custom addError
2015-07-31 08:27:37 -07:00
6fbef6d0cd
Merge pull request #1518 from rtfd/remove-unused-github-paginate
...
Remove unused projects.utils.github_paginate
2015-07-31 08:27:12 -07:00
f4b987cf06
Merge pull request #1517 from rtfd/fix-webhook-notification
...
Fix missing variable in project.tasks.webhook_notification
2015-07-31 08:26:58 -07:00
a6a1b8ec33
Merge pull request #1516 from rtfd/remove-asciidoc-builder
...
Remove doc_builder.backends.asciidoc as we do not support AsciiDoc
2015-07-31 08:26:19 -07:00
d64a42caf8
Merge pull request #1514 from rtfd/fix-random-page-view
...
Fix undeclared variable in core.views.random_page
2015-07-31 08:26:07 -07:00
d9d0985eba
Merge pull request #1513 from rtfd/fix-urls-import
...
Fix "from urls import ..." -> "from readthedocs.urls import ..."
2015-07-31 08:25:35 -07:00
b99e18b2c3
Use Django's builtin Form.add_error instead of custom addError
...
This method was added in 1.8 and can replace our custom CardForm.addError method.
2015-07-31 17:06:37 +02:00
4a313c908b
Remove unused projects.utils.github_paginate
...
It's broken, not used in the project and superseded by
oauth.utils.github_paginate.
2015-07-31 14:31:29 +02:00
69361d160c
Fix webhook_notification that seems broken since 0f045f35
...
See: 0f045f35d8 (diff-b9399e1d3499066c5564f98a620e8881R688)
2015-07-31 14:10:58 +02:00
5f53187fbb
Re-adding Project.full_epub_path method
...
It was accidentally removed in 4e7c80e7#1354 .
See: 4e7c80e741 (diff-d61f6aff9736141f30b581471d5d55ceL515)
2015-07-31 14:01:15 +02:00
1b001a8666
Remove djangome/__init__.py
...
I missed that in #1423 .
2015-07-31 13:50:48 +02:00
b7b7f226df
Remove doc_builder.backends.asciidoc as we do not support AsciiDoc
...
AsciiDoc is not part of our roadmap as decided in #533 .
2015-07-31 13:47:42 +02:00
6ebfef41b5
Fix undeclared variable in core.views.random_page
...
I broke it in c5bed3d4
2015-07-31 13:19:24 +02:00
6dd6cd803c
Fix "from urls import ..." -> "from readthedocs.urls import ..."
...
Related to #1496 .
2015-07-31 12:58:30 +02:00
e9073144e0
Move instantiation of Build class into footer.js
...
There is no other place were the build instance was used and that is nicer than
passing the object down the call chain.
Based on feedback:
https://github.com/rtfd/readthedocs.org/pull/1507#discussion_r35928305
2015-07-31 09:20:04 +02:00
0d8d794a6b
Fix READTHEDOCS_DATA loading in embed js
...
Based on feedback:
https://github.com/rtfd/readthedocs.org/pull/1507#discussion_r35928353
2015-07-31 09:19:39 +02:00
48224ccef6
Prefix imports with readthedocs
2015-07-31 09:11:53 +02:00
c9550d7855
Use privacy.backend.AdminPermission.is_admin for testing project admins
...
Based on feedback:
https://github.com/rtfd/readthedocs.org/pull/1503#discussion_r35898932
2015-07-31 08:49:58 +02:00
74a9c3a46f
Use django_dynamic_fixture's new/get instead of N/G
...
Based on feedback:
https://github.com/rtfd/readthedocs.org/pull/1503#discussion_r35933836
2015-07-31 08:49:26 +02:00
43da77890a
Adjust #1503 for readthedocs package namespacing introduced in #1496
2015-07-31 08:42:29 +02:00
dcb5049f05
Allow removing subprojects for non-subproject admins
...
Also adding tests on removing subprojects
2015-07-31 08:37:26 +02:00
0e93ce41ff
Validate user as admin of subproject when adding it to project
...
It was previously possible to add subprojects without beeing admin of them. It
should be required to be a admin. Otherwise people end up getting incorporated
into a project without knowing it or beeing asked.
Related to #1122
2015-07-31 08:37:25 +02:00
8580b54200
Fix other test imports
2015-07-30 16:04:35 -07:00
fb1489eb1c
Merge pull request #1495 from rtfd/sphinx-markdown-support
...
Default to Sphinx docs
2015-07-30 16:02:47 -07:00
b11b2427aa
Fix fox
2015-07-30 15:58:29 -07:00
a675748801
Add click tracking as diff commit to this branch
2015-07-30 15:56:25 -07:00
485aa429a4
Revert "Revert "Merge pull request #1499 from rtfd/cleanup-doc-embed-js""
...
This reverts commit 13a8162ce5
2015-07-30 15:56:25 -07:00
Gregor Müllegger
Eric Holscher